Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HTMLCanvasElement.toBlob() unconditionally in PDFPrintService #18644

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Use HTMLCanvasElement.toBlob() unconditionally in PDFPrintService #18644

merged 2 commits into from
Aug 23, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

The fallback is very old code, and according to the MDN compatibility data HTMLCanvasElement.toBlob() should be available in all browsers that we support now: https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/toBlob#browser_compatibility

@Snuffleupagus
Use HTMLCanvasElement.toBlob() unconditionally in PDFPrintService
502a429 
The fallback is very old code, and according to the MDN compatibility data `HTMLCanvasElement.toBlob()` should be available in all browsers that we support now: https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/toBlob#browser_compatibility
@Snuffleupagus
Revoke the blob-URLs used during printing in PDFPrintService
6a1b1ae
@Snuffleupagus Snuffleupagus force-pushed the PDFPrintService-unconditional-toBlob branch from 85d6728 to 6a1b1ae Compare August 23, 2024 16:40
calixteman
calixteman approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3b79b9b54f65fa1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/3b79b9b54f65fa1/output.txt

Total script time: 1.03 mins

Published

@timvandermeij
Copy link
Contributor

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/777a17d76ab8cf3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b88695ddc4a4225/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/b88695ddc4a4225/output.txt

Total script time: 8.74 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/777a17d76ab8cf3/output.txt

Total script time: 18.20 mins

  • Integration Tests: Passed

@timvandermeij timvandermeij merged commit 037c181 into mozilla:master Aug 23, 2024
6 checks passed
@timvandermeij
Copy link
Contributor

Thank you for improving this!

@Snuffleupagus Snuffleupagus deleted the PDFPrintService-unconditional-toBlob branch August 25, 2024 10:13
@YuvrajKaushal YuvrajKaushal mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
printing viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Snuffleupagus @timvandermeij @moz-tools-bot @calixteman