Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tagged images visible for screen readers (bug 1708040) #18692

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Make tagged images visible for screen readers (bug 1708040) #18692

merged 1 commit into from
Sep 5, 2024

Conversation

calixteman
Copy link
Contributor

The idea is to insert a span in the text layer with an aria-role set to img and use the bounding box provided by the attribute field in the tag dict in order to have non-null dimensions for the image to make it "visible".

@calixteman
Copy link
Contributor Author

/botio test

@mozilla mozilla deleted a comment from moz-tools-bot Sep 4, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Sep 4, 2024
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d58b6a7ff354871/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/68449f6b1bcd153/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/d58b6a7ff354871/output.txt

Total script time: 30.50 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 10

Image differences available at: http://54.241.84.105:8877/d58b6a7ff354871/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/68449f6b1bcd153/output.txt

Total script time: 46.55 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/68449f6b1bcd153/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus reviewed Sep 5, 2024
View reviewed changes
src/core/struct_tree.js Outdated Show resolved Hide resolved
src/core/struct_tree.js Outdated Show resolved Hide resolved
web/pdf_page_view.js Outdated Show resolved Hide resolved
web/struct_tree_layer_builder.js Outdated Show resolved Hide resolved
web/struct_tree_layer_builder.js Outdated Show resolved Hide resolved
web/struct_tree_layer_builder.js Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the bug1708040 branch 2 times, most recently from 487aabe to 686be4a Compare September 5, 2024 15:22
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8c3c63e6aaf65f6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4625c78ecfe29e6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/4625c78ecfe29e6/output.txt

Total script time: 9.05 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/8c3c63e6aaf65f6/output.txt

Total script time: 18.37 mins

  • Integration Tests: Passed

Snuffleupagus
Snuffleupagus approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with one more thing addressed; thank you

web/pdf_page_view.js Show resolved Hide resolved
@calixteman
Make tagged images visible for screen readers (bug 1708040)
ddba096 
The idea is to insert a span in the text layer with an aria-role set to img
and use the bounding box provided by the attribute field in the tag dict in
order to have non-null dimensions for the image to make it "visible".
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/859d23286954dda/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4cc7c85058cc2f6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/859d23286954dda/output.txt

Total script time: 30.82 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 11

Image differences available at: http://54.241.84.105:8877/859d23286954dda/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/4cc7c85058cc2f6/output.txt

Total script time: 46.61 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 4

Image differences available at: http://54.193.163.58:8877/4cc7c85058cc2f6/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 77c7ec6 into mozilla:master Sep 5, 2024
8 checks passed
@calixteman calixteman deleted the bug1708040 branch September 5, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus