[CRX] Enable WebAssembly in Chrome extension #18748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the removal of 'unsafe-eval' CSP from the Chrome extension in #18651 (as part of #15161), WebAssembly fails to load, resulting in issues such as seen in #18457.
Manifest Version 3 does not allow 'unsafe-eval', does accept the more specific 'wasm-unsafe-eval' as of Chrome 103. Note that manifest.json already sets minimum_chrome_version to 103.
This patch also adds
object-src 'self'
because it was required until Chrome 110. As of Chrome 111, the default isobject-src 'self'
andobject-src
is no longer required. We could dropobject-src
in the future, but for now we need to include it to support Chrome 103 - 110.Tested by opening the PDF from #18457. Before this fix, the page was blank. With this patch, the image is rendered.