[api-minor] Expose response headers, when available, in PDFDocumentLoadingTask
#18908
Conversation
Snuffleupagus
force-pushed
the
api-getResponseHeaders
branch
2 times, most recently
from
0a55f37 to
866b3a3
Compare
Snuffleupagus
force-pushed
the
api-getResponseHeaders
branch
from
866b3a3 to
8254677
Compare
…oadingTask` This is a feature that's been requested a few times over the years, see e.g. issue 14630, 16341, and 18792. Note that by placing the `getResponseHeaders` method in `PDFDocumentLoadingTask` it's possible to access the response headers even if loading failed, e.g. with `MissingPDFException`, which wouldn't have been possible if the method was placed elsewhere (e.g. in `PDFDocumentProxy`). Given the following JSDoc comment, this also seems generally reasonable: https://github.com/mozilla/pdf.js/blob/689ffda9df29f24e03f6e5145a096584d7f166cc/src/display/api.js#L570-L575 Considering that this functionality isn't relevant in e.g. the Firefox PDF Viewer, pre-processor statements are being used to limit the code-size impact of the implementation to GENERIC-builds as much as possible.
Snuffleupagus
force-pushed
the
api-getResponseHeaders
branch
from
8254677 to
1ae0c25
Compare
|
Closing for now, since no one seem to actually need or want this. |
|
Oh no, I noticed this late and don't have time to test it today. I really need this feature! Please reopen or merge! |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
As mentioned in #18908 (comment) that will require that you, or someone else, is willing to pay actual money for this feature:
|
This is a feature that's been requested a few times over the years, see e.g. issue #14630, #16341, and #18792.
Note that by placing the
getResponseHeadersmethod inPDFDocumentLoadingTaskit's possible to access the response headers even if loading failed, e.g. withMissingPDFException, which wouldn't have been possible if the method was placed elsewhere (e.g. inPDFDocumentProxy).Given the following JSDoc comment, this also seems generally reasonable:
pdf.js/src/display/api.js
Lines 570 to 575 in 689ffda
Considering that this functionality isn't relevant in e.g. the Firefox PDF Viewer, pre-processor statements are being used to limit the code-size impact of the implementation to GENERIC-builds as much as possible.
Please note: This will further increase the maintenance/support burden of the general PDF.js library, for a feature that's completely unused within the project itself.
Hence, if you'd like to see this patch landed, please contact me privately to discuss sponsoring this work (email address can be found in my GitHub profile).