Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api-minor] Remove the CMapCompressionType enumeration #18951

Merged
merged 2 commits into from
Oct 27, 2024
Merged

[api-minor] Remove the CMapCompressionType enumeration #18951

merged 2 commits into from
Oct 27, 2024

Commits on Oct 24, 2024

  1. Unconditionally cache built-in CMaps on the worker-thread 

    Given that we've not shipped, nor used, anything except binary CMaps for years let's just cache them unconditionally (since that's a tiny bit less code).
    @Snuffleupagus
    Snuffleupagus committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    50c291e View commit details
    Browse the repository at this point in the history

  2. [api-minor] Remove the CMapCompressionType enumeration 

    After the binary CMap format had been added there were also some ideas about *maybe* providing other formats, see [here](mozilla#8064 (comment)), however that was over seven years ago and we still only use binary CMaps.
Hence it now seems reasonable to simplify the relevant code by removing `CMapCompressionType` and instead just use a boolean to indicate the type of the built-in CMaps.
    @Snuffleupagus
    Snuffleupagus committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    b048420 View commit details
    Browse the repository at this point in the history