Re-factor the ImageResizer._goodSquareLength definition
#18965
Conversation
Move the `ImageResizer._goodSquareLength` definition into the class itself, since the current position shouldn't be necessary, and also convert it into an actually private field.
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/190018e6a63bb72/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d088223ff9d2f2e/output.txt |
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/d8d9564f2a189d6/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.241.84.105:8877/0700f057294805b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d088223ff9d2f2e/output.txt Total script time: 2.58 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/190018e6a63bb72/output.txt Total script time: 7.80 mins
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/0700f057294805b/output.txt Total script time: 20.41 mins
Image differences available at: http://54.241.84.105:8877/0700f057294805b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/d8d9564f2a189d6/output.txt Total script time: 29.49 mins
|
|
Thanks! |
Move the
ImageResizer._goodSquareLengthdefinition into the class itself, since the current position shouldn't be necessary, and also convert it into an actually private field.