Move the various DOM-factories into their own files #18988
Conversation
- Over time the number and size of these factories have increased, especially the `DOMFilterFactory` class, and this split should thus aid readability/maintainability of the code. - By introducing a couple of new import maps we can avoid bundling the `DOMCMapReaderFactory`/`DOMStandardFontDataFactory` classes in the Firefox PDF Viewer, since they are dead code there given that worker-thread fetching is always being used. - This patch has been successfully tested, by running `$ ./mach test toolkit/components/pdfjs/`, in a local Firefox artifact-build. *Note:* This patch reduces the size of the `gulp mozcentral` output by `1.3` kilo-bytes, which isn't a lot but still cannot hurt.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9136ce09f711f89/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9136ce09f711f89/output.txt Total script time: 0.99 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/23499ba8f1e065a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ffa8160c754ac2b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/23499ba8f1e065a/output.txt Total script time: 32.21 mins
Image differences available at: http://54.241.84.105:8877/23499ba8f1e065a/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/ffa8160c754ac2b/output.txt Total script time: 46.25 mins
|
Over time the number and size of these factories have increased, especially the
DOMFilterFactoryclass, and this split should thus aid readability/maintainability of the code.By introducing a couple of new import maps we can avoid bundling the
DOMCMapReaderFactory/DOMStandardFontDataFactoryclasses in the Firefox PDF Viewer, since they are dead code there given that worker-thread fetching is always being used.This patch has been successfully tested, by running
$ ./mach test toolkit/components/pdfjs/, in a local Firefox artifact-build.Note: This patch reduces the size of the
gulp mozcentraloutput by1.3kilo-bytes, which isn't a lot but still cannot hurt.