-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify saving added/modified annotations. #19026
Conversation
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9a1408c6015b576/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/491b6b2e9cf233d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/9a1408c6015b576/output.txt Total script time: 30.50 mins
Image differences available at: http://54.241.84.105:8877/9a1408c6015b576/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/491b6b2e9cf233d/output.txt Total script time: 46.12 mins
|
Having this map to collect the different changes will allow to know if some objects have already been modified.
d550867
to
4bf7787
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4ef79254e1ab017/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/44abe27a76b8270/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/4ef79254e1ab017/output.txt Total script time: 30.66 mins
Image differences available at: http://54.241.84.105:8877/4ef79254e1ab017/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/44abe27a76b8270/output.txt Total script time: 52.26 mins
Image differences available at: http://54.193.163.58:8877/44abe27a76b8270/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a fair number of code changes, so hopefully I've not missed anything important, but it looks reasonable and does seem like an overall simplification.
r=me, thank you.
Having this map to collect the different changes will allow to know if some objects have already been modified.