-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JSON imports instead of PDFJSDev.json #19068
Conversation
Sorry, but this doesn't seem to work (at all) when running |
Oh whops, I had an old branch and messed up while rebasing. |
d8f6a70
to
bae2231
Compare
Keeping it as draft because, even if ESLint 9.14 addes support for |
Could that be solved by updating the version here? Line 80 in 658a0a1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the typo in the commit message: instad -> instead
JSON imports are now supported by all tools used in PDF.js' build process. The `chromecom.js` file is bundled by webpack and import attributes are thus removed, so browser compatibility for this new syntax is not relevant.
bae2231
to
a8592d8
Compare
Oh that was it, thanks! |
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b156593f0bac9ce/output.txt |
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.241.84.105:8877/0f095ef920f5952/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/695170d8c5cc965/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b156593f0bac9ce/output.txt Total script time: 0.97 mins Published |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0f095ef920f5952/output.txt Total script time: 2.57 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/695170d8c5cc965/output.txt Total script time: 7.35 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you.
JSON imports are now supported by all tools used in PDF.js' build process. The
chromecom.js
file is bundled by webpack and import attributes are thus removed, so browser compatibility for this new syntax is not relevant.Fixes #18563