Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the code to zoom in using a pinch gesture #19124

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio-linux preview

@mozilla mozilla deleted a comment from moz-tools-bot Nov 29, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Nov 29, 2024
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subjectively to me it feels like pinching is now a little more "sluggish", since it seems to require a larger motion in order for zooming to start.

web/app.js Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

It should be better now.

@mozilla mozilla deleted a comment from moz-tools-bot Nov 29, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Nov 29, 2024
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8ec4997e9368b65/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/8ec4997e9368b65/output.txt

Total script time: 0.97 mins

Published

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comments fixed; thank you.

web/app.js Outdated Show resolved Hide resolved
web/app.js Show resolved Hide resolved
@calixteman calixteman merged commit a09ea8d into mozilla:master Nov 29, 2024
7 checks passed
@calixteman calixteman deleted the simplify_pinching branch November 29, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants