-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build date consistently (in term of tz) when executing some embedded JS (bug 1934157) #19131
Conversation
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/44a231d2311afeb/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/42f989d4c657467/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/44a231d2311afeb/output.txt Total script time: 8.89 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/42f989d4c657467/output.txt Total script time: 19.41 mins
|
e8a3348
to
d2e84d3
Compare
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7dbea91ec63e555/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/81571e24bebe646/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7dbea91ec63e555/output.txt Total script time: 2.48 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/81571e24bebe646/output.txt Total script time: 6.76 mins
|
…JS (bug 1934157) The date was create in UTC+0 and then amended in using set-Month/Date which take into account the user timezone. With this patch we build all the date in the user timezone.
d2e84d3
to
2a33708
Compare
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/09976111afddf48/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/594e7358a2d2456/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/09976111afddf48/output.txt Total script time: 2.52 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/594e7358a2d2456/output.txt Total script time: 6.37 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, assuming that the integration-tests also pass with the latest patch; thank you.
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a1c55628ca01856/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f1f8f11ce7c2f25/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a1c55628ca01856/output.txt Total script time: 8.93 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f1f8f11ce7c2f25/output.txt Total script time: 19.79 mins
|
The date was create in UTC+0 and then amended in using set-Month/Date which take into account the user timezone.
With this patch we build all the date in the user timezone.