-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Editor] Add a sidebar allowing the user to navigate between the comments in a pdf (bug 1985567) #20210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e534498 to
94d8e88
Compare
94d8e88 to
e391190
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/469543da2c98711/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/469543da2c98711/output.txt Total script time: 0.96 mins Published |
timvandermeij
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, but I'll test again once the comments are addressed.
7e5e227 to
aba0bf5
Compare
…ents in a pdf (bug 1985567) This implements what has been specified but it's still not done: we have to handle editing a comment or an annotation containing one.
aba0bf5 to
25990e4
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3320d9aab0534e5/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/3320d9aab0534e5/output.txt Total script time: 0.95 mins Published |
timvandermeij
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with passing integration tests. Nice work!
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2d63d14212ef407/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/67c4ee9b908b450/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/67c4ee9b908b450/output.txt Total script time: 18.19 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/2d63d14212ef407/output.txt Total script time: 38.39 mins
|
This implements what has been specified but it's still not done: we have to handle editing a comment or an annotation containing one.