Skip to content

Conversation

@calixteman
Copy link
Contributor

This implements what has been specified but it's still not done: we have to handle editing a comment or an annotation containing one.

@calixteman calixteman requested a review from a team as a code owner August 27, 2025 15:34
@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/469543da2c98711/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/469543da2c98711/output.txt

Total script time: 0.96 mins

Published

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, but I'll test again once the comments are addressed.

@calixteman calixteman force-pushed the comment_sidebar branch 2 times, most recently from 7e5e227 to aba0bf5 Compare August 29, 2025 11:26
…ents in a pdf (bug 1985567)

This implements what has been specified but it's still not done: we have to handle editing a comment
or an annotation containing one.
@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3320d9aab0534e5/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/3320d9aab0534e5/output.txt

Total script time: 0.95 mins

Published

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing integration tests. Nice work!

@timvandermeij
Copy link
Contributor

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2d63d14212ef407/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/67c4ee9b908b450/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/67c4ee9b908b450/output.txt

Total script time: 18.19 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/2d63d14212ef407/output.txt

Total script time: 38.39 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit 9e2e9e2 into mozilla:master Aug 30, 2025
10 checks passed
@calixteman calixteman deleted the comment_sidebar branch August 30, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants