Assign non-zero width/height to all rectangles (issue 4260)

[Snuffleupagus]

Fixes #4260.

[yurydelendik]

/botio test

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.21.233.14:8877/d78c1f2293782cd/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.22.172.223:8877/2b604ae13b4de1d/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Failed

Full output at http://107.21.233.14:8877/d78c1f2293782cd/output.txt

Total script time: 25.92 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/d78c1f2293782cd/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://107.22.172.223:8877/2b604ae13b4de1d/output.txt

Total script time: 36.35 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/2b604ae13b4de1d/reftest-analyzer.html#web=eq.log

[timvandermeij]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/d77c49f5fe2ceb0/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/d77c49f5fe2ceb0/output.txt

Total script time: 0.40 mins

Published

• Viewer: http://107.21.233.14:8877/d77c49f5fe2ceb0/web/viewer.html
• B2G Viewer: http://107.21.233.14:8877/d77c49f5fe2ceb0/extensions/b2g/content/web/viewer.html
• Extension: http://107.21.233.14:8877/d77c49f5fe2ceb0/extensions/firefox/pdf.js.xpi
• Extension (AMO): http://107.21.233.14:8877/d77c49f5fe2ceb0/extensions/firefox/pdf.js.amo.xpi

[timvandermeij]

Nice patch! It definitely solves #4260. Not sure why that one PDF gets thicker lines though.

[Snuffleupagus]

I don't really understand why issue1629 fails, but I noticed that the relevant rectangles are followed by a stroke op:

2089.4 12699.2 131.969 0 re
S
2089.4 12699.2 131.969 0 re
S
...

In the file that this PR attempts to fix, the rectangles are followed by fill, so we might have to instead do what's suggested here: #4260 (comment).

[yurydelendik]

I'm not sure it will give a different result

[yurydelendik]

issue1629 looks fine for me with the change. pdf is expecting zero-width line - we are painting that there

[yurydelendik]

/botio makeref

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/5e4c3ab4b084662/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/66676c102be7e95/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://107.22.172.223:8877/66676c102be7e95/output.txt

Total script time: 20.59 mins

• Lint: FAILED
• Make references: FAILED

[yurydelendik]

/botio-windows makeref

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/bc4367b6506630f/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/5e4c3ab4b084662/output.txt

Total script time: 25.96 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://107.22.172.223:8877/bc4367b6506630f/output.txt

Total script time: 20.89 mins

• Lint: FAILED
• Make references: FAILED

[Snuffleupagus]

Third time lucky?

/botio-windows makeref

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/80dfe9903d4ab74/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://107.22.172.223:8877/80dfe9903d4ab74/output.txt

Total script time: 19.08 mins

• Lint: FAILED
• Make references: FAILED

[timvandermeij]

/botio-windows makeref

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/a8ca4fd677651df/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://107.22.172.223:8877/a8ca4fd677651df/output.txt

Total script time: 21.51 mins

• Lint: FAILED
• Make references: Passed
• Check references: Passed

[timvandermeij]

/botio-windows lint

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/fc0fa154e91a76b/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://107.22.172.223:8877/fc0fa154e91a76b/output.txt

Total script time: 0.63 mins

• Lint: FAILED

[timvandermeij]

@yurydelendik Why does lint fail on the Windows bot? The log displays nothing indicating a problem. The reference images have now been made successfully, so I think this is ready to go.

[yurydelendik]

Thanks

[yurydelendik]

Why does lint fail on the Windows bot? The log displays nothing indicating a problem. The reference images have now been made successfully, so I think this is ready to go.

Node on windows is bad with flushing the stdout when process.exit is used. I filed #4544 -- direct jshint call might fix the issue.