Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using newChannel2 instead of newChannel in the extension. #5819

Merged
merged 1 commit into from
Mar 10, 2015
Merged

Using newChannel2 instead of newChannel in the extension. #5819

merged 1 commit into from
Mar 10, 2015

Conversation

yurydelendik
Copy link
Contributor

yurydelendik
yurydelendik reviewed Mar 10, 2015
View reviewed changes
extensions/firefox/content/PdfStreamConverter.jsm
@@ -289,12 +315,12 @@ ChromeActions.prototype = {
getService(Ci.nsIWindowWatcher).activeWindow;

var docIsPrivate = this.isInPrivateBrowsing();
var netChannel = NetUtil.newChannel(blobUri);
var netChannel = createNewChannel(blobUri, frontWindow.document, null);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just frontWindow did not work -- it has to be a node

yurydelendik added a commit that referenced this pull request Mar 10, 2015
@yurydelendik
Merge pull request #5819 from yurydelendik/newchannel2
e82c84e 
Using newChannel2 instead of newChannel in the extension.
@yurydelendik yurydelendik merged commit e82c84e into mozilla:master Mar 10, 2015
@yurydelendik yurydelendik deleted the newchannel2 branch March 10, 2015 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yurydelendik