Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRX] Respect download requests in main frame #6201

Merged
merged 1 commit into from
Jul 18, 2015

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented Jul 13, 2015

When the URL contains "=download", respect the Content-Disposition header in the Chrome extension.

Steps to verify:

  1. node make chromium
  2. Load the extension at chrome://extensions
  3. Visit https://drive.google.com/a/notable.ac/file/d/0B6YhVF9p-y2AbUJlcEI5ZGZ5Z2c/view?pli=1
  4. Click on the download button.
  5. Verify that the PDF is downloaded instead of being opened in the PDF.js Chrome extension.

Fixes half of #6106 (the printing part is still a todo, which I'll address after #6190 gets merged)

When the URL contains "=download", respect the Content-Disposition
header in the Chrome extension.
timvandermeij added a commit that referenced this pull request Jul 18, 2015
[CRX] Respect download requests in main frame
@timvandermeij timvandermeij merged commit 91ab010 into mozilla:master Jul 18, 2015
@timvandermeij
Copy link
Contributor

Works fine, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants