-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect scripted auto-print requests #6236
Conversation
Fixes mozilla#6106 To avoid future regressions, two new unit tests were added: 1. A new PDF based on the report from mozilla#6106, which contains an OpenAction of type JavaScript and a string "this.print({...}". 2. An existing PDF from https://bugzil.la/1001080 (from mozilla#4698). Although it does not matter, since we don't execute the JavaScript code, I have also changed "print(true)" to "print({})" since the print method takes an object (not a boolean). See "Printing PDF documents", page 62: http://adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/js_developer_guide.pdf
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c01c3b55fa12e01/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c01c3b55fa12e01/output.txt Total script time: 0.65 mins Published |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/e952f4992022b51/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/e952f4992022b51/output.txt Total script time: 18.66 mins
|
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/655ac8acc6d6c9f/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/655ac8acc6d6c9f/output.txt Total script time: 18.41 mins
|
Detect scripted auto-print requests
Awesome, thank you! |
Fixes #6106
As usual, see the commit mesage for a detailed explanation.
To test whether the changes work:
To manually test whether the changes work:
and check whether a print dialog opens