Rename PatternType to ShadingType to avoid confusion
#6285
Conversation
The current name is somewhat confusing, since the specification calls it `ShadingType`, see http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G7.4044105 and http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G7.3882826. The real problem, however, is that there is actually another property called `PatternType`, which makes the current code very confusing, see http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G7.1850929. Since `ShadingType` is only relevant for shading patterns (i.e. `PatternType === 2`), and *not* for tiling patterns (i.e `PatternType === 1`), this patch should help reduce confusion when reading the code.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/3d1f93b86b2c1cd/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/a5d1e990483e736/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/3d1f93b86b2c1cd/output.txt Total script time: 2.90 mins
Image differences available at: http://107.22.172.223:8877/3d1f93b86b2c1cd/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/a5d1e990483e736/output.txt Total script time: 18.82 mins
|
|
Now i understand my previous confusion :) |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/3ebffd1df54cbd8/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/3ebffd1df54cbd8/output.txt Total script time: 18.41 mins
|
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/007ec224e7b6bcf/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/007ec224e7b6bcf/output.txt Total script time: 0.66 mins Published |
…dingType Rename `PatternType` to `ShadingType` to avoid confusion
|
Looks good, thank you! |
The current name is somewhat confusing, since the specification calls it
ShadingType, see http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G7.4044105 and http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G7.3882826.The real problem, however, is that there is actually another property called
PatternType, which makes the current code very confusing, see http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G7.1850929.Since
ShadingTypeis only relevant for shading patterns (i.e.PatternType === 2), and not for tiling patterns (i.ePatternType === 1), this patch should help reduce confusion when reading the code.