Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various shading pattern regressions (issue 6287) #6292

Merged
merged 2 commits into from
Jul 31, 2015
Merged

Fix various shading pattern regressions (issue 6287) #6292

merged 2 commits into from
Jul 31, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #6287.

Note: This PR fixes the regressions, the remaining (and already tracked) shading pattern issues should be addressed separately.

@Snuffleupagus Snuffleupagus changed the title Ensure that we don't use the same typed array for both coords and colors in Mesh figures (issue 6287) Fix various shading pattern regressions (issue 6287) Jul 31, 2015
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/2d43c75f950d82e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/2d43c75f950d82e/output.txt

Total script time: 0.64 mins

Published

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_test from @timvandermeij received. Current queue size: 1

Live output at: http://107.21.233.14:8877/4856c430df78369/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 1

Live output at: http://107.22.172.223:8877/1632901756eb023/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/1632901756eb023/output.txt

Total script time: 18.42 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/4856c430df78369/output.txt

Total script time: 19.12 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/60312624d082777/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/68d77ec3e891a59/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/60312624d082777/output.txt

Total script time: 18.54 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/68d77ec3e891a59/output.txt

Total script time: 19.01 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

timvandermeij added a commit that referenced this pull request Jul 31, 2015
@timvandermeij
Merge pull request #6292 from Snuffleupagus/issue-6287
72ecbec 
Fix various shading pattern regressions (issue 6287)
@timvandermeij timvandermeij merged commit 72ecbec into mozilla:master Jul 31, 2015
@timvandermeij
Copy link
Contributor

Great work!

@Snuffleupagus Snuffleupagus deleted the issue-6287 branch July 31, 2015 20:30
hwine pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 24, 2015
@Snuffleupagus
Bug 1188344 - Uplift some PDF.js (1.1.366) regression fixes to Fx41. …
3c204f9 
…r=yury, a=ritu

 - Fixes a regression in the parsing of certain CIDFontType2 fonts with OpenType font files (bug 1186827).

 - Fixes a regression which caused keyboard buttons to become unresponsive (bug 1186842).

 - Fixes a number of shadingPattern rendering regressions (mozilla/pdf.js#6292).
@dsprenkels dsprenkels mentioned this pull request Dec 23, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core shading-pattern
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shading pattern regressions
3 participants
@Snuffleupagus @pdfjsbot @timvandermeij