fix handling of flags 1-3 in tensor shading #6310
Conversation
pi is an index in the stream and is explained on page 201 of the 32000-spec (however 1-based there), and ps is an index to something in PDF.js. I used the code from flag 0 (which works) to understand which is which. It is also important to understand that for flags 1,2 and 3, the stream is always assigned to the same coordinates and colors. What changes is which "old" coordinates and colors are assigned to what is "missing" in the stream. This is why for these flags, the code is identical except for the assignments in the first "row". (Same principle as in mozilla#6304). Note that this change will not improve the lamp_cairo.pdf file, only the two files mentioned in mozilla#6305.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/d19c8ad4f6749ea/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/d19c8ad4f6749ea/output.txt Total script time: 0.65 mins Published |
|
To be clear, this fixes two bottom two files from #6305 (comment). It the tests pass and @yurydelendik is also happy with this, I can follow this up with the /botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/1881a8be5bda655/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/8aa83228f84122b/output.txt |
|
Indeed, and of course you have my permission to use these files. |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/1881a8be5bda655/output.txt Total script time: 18.62 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/8aa83228f84122b/output.txt Total script time: 18.88 mins
|
|
great. and i see you have switched to using branches for PRs, that will make stuff easier for you. Thanks @THausherr |
|
Perfect. Thank you for the patch. |
fix handling of flags 1-3 in tensor shading
pi is an index in the stream and is explained on page 201 of the 32000-spec (however 1-based there), and ps is an index to something in PDF.js. I used the code from flag 0 (which works) to understand which is which. It is also important to understand that for flags 1,2 and 3, the stream is always assigned to the same coordinates and colors. What changes is which "old" coordinates and colors are assigned to what is "missing" in the stream. This is why for these flags, the code is identical except for the assignments in the first "row". (Same principle as in #6304). Note that this change will not improve the lamp_cairo.pdf file, only the two files mentioned in #6305.