-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also check maybeLength
when deciding if a stream is empty in Parser_makeFilter
(issue 6360, bug 1191694)
#6372
Conversation
…r_makeFilter` (issue 6360) The problem with the PDF files in the issue, besides the obviously broken XRef tables which we're able to recover from, is that many/most of the streams have Dictionaries where the `Length` entry is set to `0`. This causes us to return `NullStream`, instead of the appropriate one in `Parser_makeFilter`. Fixes 6360.
maybeLength
when deciding if a stream is empty in Parser_makeFilter
(issue 6360)maybeLength
when deciding if a stream is empty in Parser_makeFilter
(issue 6360, bug 1191694)
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/0b29914c3ae2538/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/7e434a56e711d83/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/0b29914c3ae2538/output.txt Total script time: 18.92 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/7e434a56e711d83/output.txt Total script time: 19.12 mins
|
Looks good. Thank you for the patch. /botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/602d328669d19cf/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/502721428f75d70/output.txt |
Also check `maybeLength` when deciding if a stream is empty in `Parser_makeFilter` (issue 6360, bug 1191694)
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/502721428f75d70/output.txt Total script time: 18.71 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/602d328669d19cf/output.txt Total script time: 18.75 mins
|
The problem with the PDF files in the issue, besides the obviously broken XRef tables which we're able to recover from, is that many/most of the streams have Dictionaries where the
Length
entry is set to0
. This causes us to returnNullStream
, instead of the appropriate one inParser_makeFilter
.Fixes #6360.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1191694.