Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also check maybeLength when deciding if a stream is empty in Parser_makeFilter (issue 6360, bug 1191694) #6372

Merged
merged 1 commit into from
Aug 20, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

The problem with the PDF files in the issue, besides the obviously broken XRef tables which we're able to recover from, is that many/most of the streams have Dictionaries where the Length entry is set to 0. This causes us to return NullStream, instead of the appropriate one in Parser_makeFilter.

Fixes #6360.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1191694.

…r_makeFilter` (issue 6360)

The problem with the PDF files in the issue, besides the obviously broken XRef tables which we're able to recover from, is that many/most of the streams have Dictionaries where the `Length` entry is set to `0`. This causes us to return `NullStream`, instead of the appropriate one in `Parser_makeFilter`.

Fixes 6360.
@Snuffleupagus Snuffleupagus changed the title Also check maybeLength when deciding if a stream is empty in Parser_makeFilter (issue 6360) Also check maybeLength when deciding if a stream is empty in Parser_makeFilter (issue 6360, bug 1191694) Aug 20, 2015
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/0b29914c3ae2538/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/7e434a56e711d83/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/0b29914c3ae2538/output.txt

Total script time: 18.92 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/7e434a56e711d83/output.txt

Total script time: 19.12 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor

Looks good. Thank you for the patch.

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/602d328669d19cf/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/502721428f75d70/output.txt

yurydelendik added a commit that referenced this pull request Aug 20, 2015
Also check `maybeLength` when deciding if a stream is empty in `Parser_makeFilter` (issue 6360, bug 1191694)
@yurydelendik yurydelendik merged commit 23cb01c into mozilla:master Aug 20, 2015
@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/502721428f75d70/output.txt

Total script time: 18.71 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/602d328669d19cf/output.txt

Total script time: 18.75 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-6360 branch August 20, 2015 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants