Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback in readCmapTable, instead of using error, for TrueType fonts with unsupported cmap formats (bug 1200096) #6407

Merged
merged 1 commit into from
Sep 5, 2015

Commits on Sep 1, 2015

  1. Fallback in readCmapTable, instead of using error, for TrueType f…

    …onts with unsupported cmap formats (bug 1200096)
    
    Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1200096.
    
    The problematic font has a `format 2` cmap, which we've never supported properly. Prior to PR 2606, we were able to fallback to a working state, despite not having proper support for that cmap format.
    
    Obviously the best/correct solution would be to implement actual support for more cmap formats[1]. However, I'm hoping that a simple patch will be OK for now, given that:
     - `format 2` cmaps seem to be quite rare in practice, since this has been broken for 2.5 years before anyone noticed.
     - Having a simple patch will make potential uplifts a lot easier.
    
    [1] See the specification at https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6cmap.html
    Snuffleupagus committed Sep 1, 2015
    Configuration menu
    Copy the full SHA
    0fb31a4 View commit details
    Browse the repository at this point in the history