Add a totalLength getter to OperatorList, since the length is zero after flushing
#6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ero after flushing In the `RenderPageRequest` handler in `worker.js`, we attempt to print an `info` message containing the rendering time and the length of the operator list. The latter is currently broken (and has been for quite some time), since the `length` of an `OperatorList` is reset when flushing occurs. This patch attempts to rectify this, by adding a getter which keeps track of the total length.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/51eaeec07ffd54e/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/2b1d6758ea9ab10/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/51eaeec07ffd54e/output.txt Total script time: 18.78 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/2b1d6758ea9ab10/output.txt Total script time: 19.99 mins
|
|
Looks good to me, but it would be great if @yurydelendik or @brendandahl could check this too just to be sure. |
yurydelendik
added a commit
that referenced
this pull request
Oct 28, 2015
Add a `totalLength` getter to `OperatorList`, since the `length` is zero after flushing
|
Thank you for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
RenderPageRequesthandler inworker.js, we attempt to print aninfomessage containing the rendering time and the length of the operator list. The latter is currently broken (and has been for quite some time), since thelengthof anOperatorListis reset when flushing occurs.This patch attempts to rectify this, by adding a getter which keeps track of the total length.