[api-minor] Allows a worker to handle multiple documents. #6571

yurydelendik · 2015-10-27T18:59:52Z

Added features:

Allows create a PDFWorker object prior getDocument use
Every loading task has unique docId, that allows generate unique fonts and use several PDF documents inside single worker
FontLoader refactored to not be global

yurydelendik · 2015-10-27T19:26:49Z

Fixes #5992
Alternative solution for #5984
Shall address #6209, #6205, #5148, #4228

existentialism · 2015-10-27T20:32:53Z

src/display/api.js

+    this._worker = null;
+
+    /**
+     * Unique document loading task id -- used in MessageHanlders.


Nit: typo MessageHandlers

yurydelendik · 2015-10-28T13:41:57Z

Some unit tests added to test PDFWorker functionality.

/botio test

Snuffleupagus · 2015-10-28T15:20:40Z

I've gone through (and manually tested) this PR, and it all looks good to me!

@brendandahl Would you mind looking through this as well?

Snuffleupagus · 2015-11-10T11:35:38Z

src/display/api.js

+ *                    MessageHandler is known.
+ * @private
+ */
+function _fetchDocument(worker, source, pdfDataRangeTransport, docId) {


Nit: the worker parameter is missing in the JSDoc comments above.

timvandermeij · 2015-11-20T14:48:42Z

/botio-linux preview

pdfjsbot · 2015-11-20T14:48:43Z

From: Bot.io (Linux)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/af51956bde57538/output.txt

pdfjsbot · 2015-11-20T14:49:30Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/af51956bde57538/output.txt

Total script time: 0.78 mins

Published

timvandermeij · 2015-11-20T14:49:59Z

/botio test

pdfjsbot · 2015-11-20T14:50:00Z

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/68d9e8a784563b7/output.txt

yurydelendik · 2015-11-24T19:43:22Z

/botio test

pdfjsbot · 2015-11-24T19:43:22Z

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/2ec1e7b8a44c8e0/output.txt

pdfjsbot · 2015-11-24T19:43:22Z

From: Bot.io (Linux)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/d8f33d17ecf2603/output.txt

pdfjsbot · 2015-11-24T20:01:46Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/2ec1e7b8a44c8e0/output.txt

Total script time: 18.39 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

pdfjsbot · 2015-11-24T20:03:12Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/d8f33d17ecf2603/output.txt

Total script time: 19.83 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

timvandermeij · 2015-11-24T21:39:51Z

/botio-linux preview

pdfjsbot · 2015-11-24T21:39:52Z

From: Bot.io (Linux)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 1

Live output at: http://107.21.233.14:8877/9c48288dbcad83c/output.txt

pdfjsbot · 2015-11-24T21:40:52Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/9c48288dbcad83c/output.txt

Total script time: 0.77 mins

Published

[api-minor] Allows a worker to handle multiple documents.

timvandermeij · 2015-11-24T21:42:52Z

Nice work!

yurydelendik added the 4-work-in-progress label Oct 27, 2015

yurydelendik force-pushed the worker branch 2 times, most recently from c821a4a to e736a3f Compare October 27, 2015 20:07

existentialism reviewed Oct 27, 2015
View reviewed changes

yurydelendik force-pushed the worker branch 6 times, most recently from 7d2aa9a to 7b5b3d4 Compare October 28, 2015 13:40

yurydelendik removed the 4-work-in-progress label Oct 28, 2015

Snuffleupagus assigned brendandahl Oct 28, 2015

Snuffleupagus added the core label Oct 28, 2015

yurydelendik force-pushed the worker branch from 7b5b3d4 to 225b3f5 Compare October 28, 2015 21:57

timvandermeij mentioned this pull request Oct 28, 2015

Fix font rendering when rendering multiple PDFs in parallel #6209

Merged

2 tasks

yurydelendik mentioned this pull request Oct 29, 2015

Error on PDFDocumentLoadingTask.destroy: Cannot read property 'objs' of undefined #6577

Closed

yurydelendik force-pushed the worker branch from 225b3f5 to 6a66f0e Compare November 10, 2015 00:57

Snuffleupagus reviewed Nov 10, 2015
View reviewed changes

yurydelendik force-pushed the worker branch from 6a66f0e to 6a9cf00 Compare November 10, 2015 17:57

yurydelendik mentioned this pull request Nov 16, 2015

Allow worker to host/parse mutilple documents #5992

Closed

3 tasks

yurydelendik force-pushed the worker branch from 6a9cf00 to 364dcbf Compare November 16, 2015 14:53

timvandermeij mentioned this pull request Nov 19, 2015

enable multiple pdf documents in one html page - fixing #5148 #5984

Closed

yurydelendik force-pushed the worker branch from 1b9a204 to 60fdc19 Compare November 24, 2015 19:25

yurydelendik added 2 commits November 24, 2015 13:27

Creates PDFWorker, separates fetchDocument from transport.

09772e1

Refactors FontLoader to group fonts per document.

06c1904

yurydelendik force-pushed the worker branch from 60fdc19 to 06c1904 Compare November 24, 2015 19:27

timvandermeij added a commit that referenced this pull request Nov 24, 2015

Merge pull request #6571 from yurydelendik/worker

c2dfe9e

[api-minor] Allows a worker to handle multiple documents.

timvandermeij merged commit c2dfe9e into mozilla:master Nov 24, 2015

This was referenced Nov 24, 2015

Multiple PDF documents in one HTML page #5148

Closed

After opening a lot (≥20) PDF files, the latter ones do not load #4228

Closed

yurydelendik mentioned this pull request Nov 26, 2015

Worker shall wait for MessageHandler to be created at api side. #6693

Merged

Snuffleupagus mentioned this pull request Nov 28, 2015

Replace font.bindDOM() with font.createFontFaceRule() in the FontLoader for MOZCENTRAL specific code (PR 6571 follow-up) #6700

Merged

Snuffleupagus mentioned this pull request Dec 12, 2015

Reset the styleElement when clearing out loaded fonts (bug 1232071) #6745

Merged

Snuffleupagus mentioned this pull request Jan 29, 2016

[Firefox] disableWorker=true no longer works in the addon/built-in version #6937

Closed

Snuffleupagus mentioned this pull request Mar 16, 2016

Pass the PDFJS.postMessageTransfer parameter to the worker, so that the MessageHandler can be setup correctly in createDocumentHandler (issue 6957) #7088

Merged

yurydelendik mentioned this pull request May 16, 2016

pdf.js loads a new copy of pdf.worker.js every time I call PDFJS.getDocument #7333

Closed

ctessier mentioned this pull request Sep 28, 2016

Worker was destroyed (multiple PDF viewer in one page) #7679

Closed

yurydelendik mentioned this pull request Oct 5, 2016

Example to use multiple PDF.js viewer in same page #7693

Closed

Snuffleupagus mentioned this pull request Oct 24, 2016

Distorted bold text #7751

Closed

yurydelendik mentioned this pull request Dec 19, 2016

Random / apparent "bolding" / corruption #7136

Closed

Snuffleupagus mentioned this pull request May 31, 2017

. #8465

Closed

ishanuda mentioned this pull request Jan 25, 2020

Support for Multiple PDF viewers on the same page (e.g. tabs) stephanrauh/ngx-extended-pdf-viewer#196

Closed

Snuffleupagus mentioned this pull request Oct 2, 2022

[api-minor] Stop setting an id on the styleElement used with CSS font-loading #15534

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[api-minor] Allows a worker to handle multiple documents. #6571

[api-minor] Allows a worker to handle multiple documents. #6571

yurydelendik commented Oct 27, 2015

yurydelendik commented Oct 27, 2015

existentialism Oct 27, 2015

yurydelendik commented Oct 28, 2015

Snuffleupagus commented Oct 28, 2015

Snuffleupagus Nov 10, 2015

timvandermeij commented Nov 20, 2015

pdfjsbot commented Nov 20, 2015

pdfjsbot commented Nov 20, 2015

timvandermeij commented Nov 20, 2015

pdfjsbot commented Nov 20, 2015

yurydelendik commented Nov 24, 2015

pdfjsbot commented Nov 24, 2015

pdfjsbot commented Nov 24, 2015

pdfjsbot commented Nov 24, 2015

pdfjsbot commented Nov 24, 2015

timvandermeij commented Nov 24, 2015

pdfjsbot commented Nov 24, 2015

pdfjsbot commented Nov 24, 2015

timvandermeij commented Nov 24, 2015

[api-minor] Allows a worker to handle multiple documents. #6571

[api-minor] Allows a worker to handle multiple documents. #6571

Conversation

yurydelendik commented Oct 27, 2015

yurydelendik commented Oct 27, 2015

existentialism Oct 27, 2015

Choose a reason for hiding this comment

yurydelendik commented Oct 28, 2015

Snuffleupagus commented Oct 28, 2015

Snuffleupagus Nov 10, 2015

Choose a reason for hiding this comment

timvandermeij commented Nov 20, 2015

pdfjsbot commented Nov 20, 2015

From: Bot.io (Linux)

Received

pdfjsbot commented Nov 20, 2015

From: Bot.io (Linux)

Success

Published

timvandermeij commented Nov 20, 2015

pdfjsbot commented Nov 20, 2015

From: Bot.io (Windows)

Received

yurydelendik commented Nov 24, 2015

pdfjsbot commented Nov 24, 2015

From: Bot.io (Windows)

Received

pdfjsbot commented Nov 24, 2015

From: Bot.io (Linux)

Received

pdfjsbot commented Nov 24, 2015

From: Bot.io (Windows)

Success

pdfjsbot commented Nov 24, 2015

From: Bot.io (Linux)

Success

timvandermeij commented Nov 24, 2015

pdfjsbot commented Nov 24, 2015

From: Bot.io (Linux)

Received

pdfjsbot commented Nov 24, 2015

From: Bot.io (Linux)

Success

Published

timvandermeij commented Nov 24, 2015