Improve reliability of the test server #6600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Rob--W
commented
Nov 6, 2015
Rob--W
commented
- replace // with / (otherwise http://localhost:8888// links to e.g. http://src/ instead of http://localhost:8888/src).
- Solve XSS issue (file names should be sanitized, not output as-is).
- Prevent server from crashing if there is a stat error (e.g. permission error or file not found (e.g. broken symlink)).
Rob--W
force-pushed
the
test-server-improved
branch
from
027483a
to
b25b541
Compare
| // Escape untrusted input so that it can safely be used in a HTML response | ||
| // in HTML and in HTML attributes. | ||
| return untrusted | ||
| .replace(/&/g, '&l;') |
- replace // with / (otherwise http://localhost:8888// links to e.g. http://src/ instead of http://localhost:8888/src). - Solve XSS issue (file names should be sanitized, not output as-is). - Prevent server from crashing if there is a stat error (e.g. permission error or file not found (e.g. broken symlink)).
Rob--W
force-pushed
the
test-server-improved
branch
from
b25b541
to
b0ff49e
Compare
yurydelendik
added a commit
that referenced
this pull request
Nov 11, 2015
Improve reliability of the test server
|
Thank you for the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.