Fix 'Ready' message sequence for Firefox ext disabled worker.

[yurydelendik]

Fixes #6937

It's a little bit messy since we are handling async messages in sync style. We cannot just add e.g. setTimeout or Promises because in some cases we dispose original objects, e.g. arrays in operator list, and cannot clone objects with JSON since some of them are typed arrays.

Proper and full solution will be to make our fake channel act like a real one.

[yurydelendik]

I guess it's something random that was caused by this patch :/

[Snuffleupagus]

I guess it's something random that was caused by this patch :/

That's unfortunate. However, given that the disableWorker issue is limited to the Firefox versions of PDF.js (where it's not simple to disable workers in the first place, and definitely not recommended), I think that we can live with this at least for now.

Proper and full solution will be to make our fake channel act like a real one.

Obviously it'd be nice to get it fixed as described, but it might not need to be a too high priority.

[timvandermeij]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/ac29a871ef2899f/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/ac29a871ef2899f/output.txt

Total script time: 0.82 mins

Published

• Viewer: http://107.21.233.14:8877/ac29a871ef2899f/web/viewer.html
• B2G Viewer: http://107.21.233.14:8877/ac29a871ef2899f/extensions/b2g/content/web/viewer.html
• Extension: http://107.21.233.14:8877/ac29a871ef2899f/extensions/firefox/pdf.js.xpi

[timvandermeij]

/botio test

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/35725a20af3340d/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/20c55f626f27018/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/35725a20af3340d/output.txt

Total script time: 19.75 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/20c55f626f27018/output.txt

Total script time: 20.99 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[timvandermeij]

The previous failures are related to #6944. A fresh test run shows that all is fine now, so I would say that this patch is fine. @Snuffleupagus I would say that this is good to merge if the solution is fine and the original problem is fixed.

[Snuffleupagus]

/botio test

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/ce2245434bed1e6/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/2db5ae96f4a9522/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Failed

Full output at http://107.21.233.14:8877/2db5ae96f4a9522/output.txt

Total script time: 14.01 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/2db5ae96f4a9522/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/ce2245434bed1e6/output.txt

Total script time: 19.93 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[yurydelendik]

Looks like a bad timing, and this patch might make thing less intermittent in terms of problem. However I still cannot reproduce that on real computer (ubuntu ff 46a2).

But I would like to push it to aurora. @Snuffleupagus can you check if it fixes the issue, let's open the bug and uplift that to aurora?

[Snuffleupagus]

Sorry for the delay here!
Just so I understand correctly: the current patch is still necessary even with PR #6948 (based on this comment)? If that is correct, please land this PR with r=me.

[yurydelendik]

Just so I understand correctly: the current patch is still necessary even with PR #6948

Those patches independent and both address the same issue. However this one makes our testing angrier, but it's easy to use in the uplift to aurora. So I'm thinking to push it only to aurora, while we can, but don't accept it in our repo.

[Snuffleupagus]

So I'm thinking to push it only to aurora, while we can, but don't accept it in our repo.

This seems fine to me.