-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes insertion of blank pages during print if page sizes differ #7005
Conversation
I wonder if we can just get away with #printContainer and #printContainer > div Not sure what kind of affect setting of the canvas'es style width/height will have on mozPrintCallback polyfill for other browsers. I wish we could set real size of the paper here in inches or mm. |
We probably can once https://bugzilla.mozilla.org/show_bug.cgi?id=851937 is fixed. On my plate. |
I confirm that this fixes the mentioned Bugzilla issues. Furthermore it fixes #4041 too. However, it regresses #6461 (more specifically, this file from that issue: https://www.dropbox.com/s/6lves3ge8s2u48g/bedcard.pdf?dl=0) as it stretches it to match 100% height. @tobytailor Could you look into what is causing this? |
@timvandermeij fixed via 708895f. |
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/ce4065b613b1c8c/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/ce4065b613b1c8c/output.txt Total script time: 1.01 mins Published |
Thank you for the patch! (I have tested this with IE, Edge, Firefox and Chrome and found no regressions for all problematic PDF files from older/current issues, only improvements in terms of no more blank pages and improved scaling.) |
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1020878, https://bugzilla.mozilla.org/show_bug.cgi?id=972677 and probably more.