-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-minor] Don't render highlight/underline/squiggly/strikeout annotations that doesn't have popup #7012
Conversation
…doesn't have popup
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/43dc779f58612be/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/43dc779f58612be/output.txt Total script time: 0.91 mins Published |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/913781cc7c6a0a6/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/9186344c2a2eb44/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/913781cc7c6a0a6/output.txt Total script time: 20.22 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/9186344c2a2eb44/output.txt Total script time: 21.90 mins
|
don't render highlight/underline/squiggly/strikeout annotations that doesn't have popup
Thank you! Let's do this for now, but there is an underlying issue that I would like to fix, for which I will open separate issues. |
Given that PR #6780 added support for annotation regression testing, it would have been a very good idea to include a test-case in this PR. Edit: It looks like PR #7016 takes care of this, so in that case the comment above can be disregarded. |
Fixes #6838