Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-minor] Don't render highlight/underline/squiggly/strikeout annotations that doesn't have popup #7012

Merged
merged 1 commit into from
Feb 22, 2016

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Feb 22, 2016

Fixes #6838

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/43dc779f58612be/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/913781cc7c6a0a6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/9186344c2a2eb44/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/913781cc7c6a0a6/output.txt

Total script time: 20.22 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/9186344c2a2eb44/output.txt

Total script time: 21.90 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

timvandermeij added a commit that referenced this pull request Feb 22, 2016
don't render highlight/underline/squiggly/strikeout annotations that doesn't have popup
@timvandermeij timvandermeij merged commit ebe6fb2 into mozilla:master Feb 22, 2016
@timvandermeij
Copy link
Contributor

Thank you! Let's do this for now, but there is an underlying issue that I would like to fix, for which I will open separate issues.

@xlc xlc deleted the fix-annotation-popup branch February 22, 2016 21:00
@timvandermeij timvandermeij changed the title don't render highlight/underline/squiggly/strikeout annotations that doesn't have popup [api-minor] Don't render highlight/underline/squiggly/strikeout annotations that doesn't have popup Feb 22, 2016
@Snuffleupagus
Copy link
Collaborator

Given that PR #6780 added support for annotation regression testing, it would have been a very good idea to include a test-case in this PR.
So, can someone please create a follow-up that adds a test-case for this!?

Edit: It looks like PR #7016 takes care of this, so in that case the comment above can be disregarded.

@xlc xlc restored the fix-annotation-popup branch March 10, 2016 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants