Removes global PDFJS usage from the src/core/. #7053

yurydelendik · 2016-03-02T17:41:12Z

No description provided.

yurydelendik · 2016-03-02T17:46:36Z

TODOs:

move shared/global.js to display/global.js
test with examples and in pdfjs-dist configuration
transfer verbosity from main thread to the worker's
refactor PDFJS.WorkerMessageHandler
move some tests from test/unit/util_spec.js into test/unit/dom_utils_spec.js

timvandermeij · 2016-03-02T20:42:33Z

src/core/bidi.js


-var PDFJS = sharedGlobal.PDFJS;
-
-var bidi = PDFJS.bidi = (function bidiClosure() {


Now that this is gone, will the export line at the end of the file still work?

line 120 below defines bidi function

yurydelendik · 2016-03-02T20:57:43Z

src/core/document.js

@@ -526,7 +530,7 @@ var PDFDocument = (function PDFDocumentClosure() {
      var pageFactory = {
        createPage: function (pageIndex, dict, ref, fontCache) {
          return new Page(self.pdfManager, self.xref, pageIndex, dict, ref,
-                          fontCache);
+                          fontCache, self.evaluatorOptions);


self.pdfManage.evaluatorOptions ?

Snuffleupagus · 2016-03-02T21:13:51Z

Some of the functions that are moved from src/shared/util.js into src/display/dom_utils.js have unit tests. For consistency, can those tests be moved from test/unit/util_spec.js into test/unit/dom_utils_spec.js instead?

Snuffleupagus · 2016-03-05T10:33:33Z

The test failures are most likely caused by not passing in the CMap options when doing new Font(...) in evaluator.js, see evaluator.js#L1992 and evaluator.js#L2085.

Also, a nit, but shouldn't it ideally be named cMapOptions (note the upper-case M), such that it's consistent with the current cMapUrl/cMapPacked properties (given that these are Character Map related, as opposed to the also existing TrueType cmap table).

yurydelendik · 2016-03-07T19:19:48Z

The test failures are most likely caused by not passing in the CMap options when doing new Font(...) in evaluator.js, see evaluator.js#L1992 and evaluator.js#L2085.

That was it (plus one another thing with passing options as argument in LocalPdfManager)

Also, a nit, but shouldn't it ideally be named cMapOptions (note the upper-case M), such that it's consistent with the current cMapUrl/cMapPacked properties

Renamed

/botio test

yurydelendik · 2016-03-23T22:35:46Z

/botio test

pdfjsbot · 2016-03-23T22:35:48Z

From: Bot.io (Linux)

Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.21.233.14:8877/02ad5968ac4805b/output.txt

pdfjsbot · 2016-03-23T22:37:53Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/401b4802a8f4a97/output.txt

Total script time: 13.78 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/401b4802a8f4a97/reftest-analyzer.html#web=eq.log

timvandermeij · 2016-03-23T22:54:52Z

src/display/canvas.js

  }
-}(this, function (exports, sharedUtil, displayPatternHelper, displayWebGL) {
+}(this, function (exports, sharedUtil, displayDOMUtils, displayPatternHelper,


Why are all the changes in this file necessary? As far as I can see you're just adding displayDOMUtils but not using it in the file.

canvas.js has some PDFJS references (e.g. PDFJS.hasCanvasTypedArrays) and dom_utils.js has these -- it will be changed once we move all display/ PDFJS references in one file (display/global.js)

I see, thanks for the clarification!

pdfjsbot · 2016-03-23T23:27:35Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/20eacbdff32384a/output.txt

Total script time: 3.92 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/20eacbdff32384a/reftest-analyzer.html#web=eq.log

pdfjsbot · 2016-03-23T23:44:08Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/027a5953f547b94/output.txt

Total script time: 20.47 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

yurydelendik · 2016-03-25T15:20:23Z

TEST-PASS | load test issue6108 | in firefox

Firefox is often stops after the test above: issue6961 - the #6961 is a performance issue. Maybe timeout needs to be increased. The problem does not appear when run on the botio-windows from command line. Will continue trying using gh botio interface with increased timeout.

/botio-windows test

pdfjsbot · 2016-03-25T15:20:23Z

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/8085979e5920ad3/output.txt

pdfjsbot · 2016-03-25T15:40:08Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/8085979e5920ad3/output.txt

Total script time: 19.74 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

yurydelendik · 2016-03-25T15:42:41Z

/botio-windows test

pdfjsbot · 2016-03-25T15:42:41Z

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/6eabc43343852d0/output.txt

pdfjsbot · 2016-03-25T16:02:27Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/6eabc43343852d0/output.txt

Total script time: 19.77 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

yurydelendik · 2016-03-25T16:06:19Z

/botio test

pdfjsbot · 2016-03-25T16:06:19Z

From: Bot.io (Linux)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/d381e9ed88752d4/output.txt

pdfjsbot · 2016-03-25T16:06:19Z

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/8e7b3f476a335ba/output.txt

pdfjsbot · 2016-03-25T16:26:18Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/8e7b3f476a335ba/output.txt

Total script time: 19.98 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

yurydelendik · 2016-03-25T17:04:39Z

/botio-windows test

pdfjsbot · 2016-03-25T17:04:39Z

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.22.172.223:8877/7b0f60e7be9f89a/output.txt

pdfjsbot · 2016-03-25T17:06:21Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/d381e9ed88752d4/output.txt

Total script time: 60.00 mins

pdfjsbot · 2016-03-25T17:30:23Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/7b0f60e7be9f89a/output.txt

Total script time: 19.83 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

yurydelendik · 2016-03-25T18:16:10Z

/botio test

pdfjsbot · 2016-03-25T18:16:11Z

From: Bot.io (Linux)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/e1fc89e69266f2c/output.txt

pdfjsbot · 2016-03-25T18:16:11Z

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/be0aca3444beac9/output.txt

pdfjsbot · 2016-03-25T18:36:10Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/be0aca3444beac9/output.txt

Total script time: 19.98 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

pdfjsbot · 2016-03-25T18:38:14Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/e1fc89e69266f2c/output.txt

Total script time: 22.05 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

timvandermeij · 2016-03-25T19:12:10Z

/botio-linux preview

pdfjsbot · 2016-03-25T19:12:11Z

From: Bot.io (Linux)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/7181a4628b9ff42/output.txt

pdfjsbot · 2016-03-25T19:13:11Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/7181a4628b9ff42/output.txt

Total script time: 0.99 mins

Published

timvandermeij · 2016-03-25T19:14:31Z

/botio test

pdfjsbot · 2016-03-25T19:14:31Z

From: Bot.io (Linux)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/471377ca2a8b7b1/output.txt

pdfjsbot · 2016-03-25T19:14:31Z

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/d889f5f03ce095d/output.txt

pdfjsbot · 2016-03-25T19:34:19Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/d889f5f03ce095d/output.txt

Total script time: 19.78 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

pdfjsbot · 2016-03-25T19:36:38Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/471377ca2a8b7b1/output.txt

Total script time: 22.11 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

yurydelendik added the 4-work-in-progress label Mar 2, 2016

timvandermeij reviewed Mar 2, 2016
View reviewed changes

timvandermeij added the core label Mar 2, 2016

yurydelendik reviewed Mar 2, 2016
View reviewed changes

yurydelendik force-pushed the rm-pdfjs-core branch from d8c75f3 to 140164a Compare March 3, 2016 01:17

yurydelendik removed the 4-work-in-progress label Mar 4, 2016

yurydelendik force-pushed the rm-pdfjs-core branch from 1558d64 to 419c239 Compare March 7, 2016 19:18

yurydelendik force-pushed the rm-pdfjs-core branch from 419c239 to e0bda5b Compare March 11, 2016 13:13

yurydelendik force-pushed the rm-pdfjs-core branch 4 times, most recently from ae8351c to d65387b Compare March 23, 2016 22:35

yurydelendik force-pushed the rm-pdfjs-core branch from d65387b to 7cf0e75 Compare March 23, 2016 22:38

timvandermeij reviewed Mar 23, 2016
View reviewed changes

yurydelendik force-pushed the rm-pdfjs-core branch from 7cf0e75 to c44c7b3 Compare March 23, 2016 23:20

yurydelendik added 4 commits March 23, 2016 19:24

Removes global PDFJS usage from the src/core/.

bda5e62

Makes WorkerMessageHandler non-global.

e372f36

Moves shared/global to display/global

a8e5912

Proxy global PDFJS.verbosity to properly configure shared/util.

2fa4dd6

yurydelendik force-pushed the rm-pdfjs-core branch from 54d2310 to 2fa4dd6 Compare March 25, 2016 17:33

yurydelendik mentioned this pull request Mar 25, 2016

Investigate issue6961 test due to its frequent test failures #7112

Closed

brendandahl merged commit df7afcf into mozilla:master Mar 25, 2016


		var PDFJS = sharedGlobal.PDFJS;

		var bidi = PDFJS.bidi = (function bidiClosure() {

Removes global PDFJS usage from the src/core/. #7053

Removes global PDFJS usage from the src/core/. #7053

Conversation

yurydelendik commented Mar 2, 2016

yurydelendik commented Mar 2, 2016

timvandermeij Mar 2, 2016

Choose a reason for hiding this comment

yurydelendik Mar 2, 2016

Choose a reason for hiding this comment

yurydelendik Mar 2, 2016

Choose a reason for hiding this comment

Snuffleupagus commented Mar 2, 2016

Snuffleupagus commented Mar 5, 2016

yurydelendik commented Mar 7, 2016

yurydelendik commented Mar 23, 2016

pdfjsbot commented Mar 23, 2016

From: Bot.io (Linux)

Received

pdfjsbot commented Mar 23, 2016

From: Bot.io (Linux)

Failed

timvandermeij Mar 23, 2016

Choose a reason for hiding this comment

yurydelendik Mar 23, 2016

Choose a reason for hiding this comment

timvandermeij Mar 23, 2016

Choose a reason for hiding this comment

pdfjsbot commented Mar 23, 2016

From: Bot.io (Linux)

Failed

pdfjsbot commented Mar 23, 2016

From: Bot.io (Windows)

Success

yurydelendik commented Mar 25, 2016

pdfjsbot commented Mar 25, 2016

From: Bot.io (Windows)

Received

pdfjsbot commented Mar 25, 2016

From: Bot.io (Windows)

Success

yurydelendik commented Mar 25, 2016

pdfjsbot commented Mar 25, 2016

From: Bot.io (Windows)

Received

pdfjsbot commented Mar 25, 2016

From: Bot.io (Windows)

Success

yurydelendik commented Mar 25, 2016

pdfjsbot commented Mar 25, 2016

From: Bot.io (Linux)

Received

pdfjsbot commented Mar 25, 2016

From: Bot.io (Windows)

Received

pdfjsbot commented Mar 25, 2016

From: Bot.io (Windows)

Success

yurydelendik commented Mar 25, 2016

pdfjsbot commented Mar 25, 2016

From: Bot.io (Windows)

Received

pdfjsbot commented Mar 25, 2016

From: Bot.io (Linux)

Failed

pdfjsbot commented Mar 25, 2016

From: Bot.io (Windows)

Success

yurydelendik commented Mar 25, 2016

pdfjsbot commented Mar 25, 2016

From: Bot.io (Linux)

Received

pdfjsbot commented Mar 25, 2016

From: Bot.io (Windows)

Received

pdfjsbot commented Mar 25, 2016

From: Bot.io (Windows)

Success

pdfjsbot commented Mar 25, 2016

From: Bot.io (Linux)

Success