Allow SMask be resumed after restore() and better transform after SMask #7176
Conversation
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/7664540a29b23d3/output.txt |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 1 Live output at: http://107.22.172.223:8877/35f453e8f8d54c4/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/985032d259735d6/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/7664540a29b23d3/output.txt Total script time: 1.58 mins Published |
|
TODO:
#7143 is combination of (Issue 6165 and Bug 1199237 but in weird way) |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/35f453e8f8d54c4/output.txt Total script time: 20.22 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/985032d259735d6/output.txt Total script time: 22.29 mins
|
yurydelendik
changed the title
| @@ -869,6 +870,11 @@ var CanvasGraphics = (function CanvasGraphicsClosure() { | |||
| }, | |||
|
|
|||
| endDrawing: function CanvasGraphics_endDrawing() { | |||
| // Finishing all opened operations such as SMask group painting. | |||
| if (this.current.activeSMask !== null) { | |||
| this.endSMaskGroup(); | |||
There was a problem hiding this comment.
Nit: please reduce the indentation here.
yurydelendik
force-pushed
the
smask-resume
branch
2 times, most recently
from
2ca4f9a
to
9040262
Compare
| this.ctx.save(); // save is needed since SMask will be resumed. | ||
| copyCtxState(groupCtx, this.ctx); | ||
|
|
||
| // Saving save for resuming. |
There was a problem hiding this comment.
Nit: Shouldn't this be Saving state ... instead?
|
This looks great, awesome work! And the added comments was most helpful when trying to make sense of the code. |
yurydelendik
force-pushed
the
smask-resume
branch
from
9040262
to
d76db41
Compare
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/e12ccc3c6f3f87a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/755d8854d2d2147/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/755d8854d2d2147/output.txt Total script time: 20.36 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/e12ccc3c6f3f87a/output.txt Total script time: 22.58 mins
|
|
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/f8f5d7066b3589c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/d9beb54b332d290/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/d9beb54b332d290/output.txt Total script time: 20.12 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/f8f5d7066b3589c/output.txt Total script time: 22.01 mins
|
|
For future reference, this also fixed https://bugzilla.mozilla.org/show_bug.cgi?id=1025247. |
... also fixes finalizing SMask at the end of operator list.
Fixes most of #7011