-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug 1260585] Stops bleeding of pattern edges for mesh. #7184
Conversation
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/51cc8bc774528b8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/441dbf84c285047/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/441dbf84c285047/output.txt Total script time: 20.21 mins
Image differences available at: http://107.22.172.223:8877/441dbf84c285047/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/51cc8bc774528b8/output.txt Total script time: 22.43 mins
Image differences available at: http://107.21.233.14:8877/51cc8bc774528b8/reftest-analyzer.html#web=eq.log |
Looks good, thank you for the patch! /botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/99b63d2477c26c3/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/824250db21e809b/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/99b63d2477c26c3/output.txt Total script time: 20.09 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/824250db21e809b/output.txt Total script time: 22.00 mins
|
In reftest analyzer, I see extra pixels on last image row (firefox-issue4227-page1 for example). They are not displayed in other viewers (okular on Debian for example). It may be a rounding issue. |
It's rounding issue, yes. When triangles are painted, it's doing it in int numbers. The result will depend on scale too. |
The issue affects both Firefox and Chrome (not Safari though). Workaround due to how wide spread is the issue: adding transparent edges on all four sides of the pattern.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1260585