Use Uint8ClampedArray, when returning data, and remove manual clamping in src/core/jpg.js (issue 4901)
#8778
Conversation
… mode At this point, the default viewer is already not usable in older browsers in `gulp server` mode, since we only run the code through Babel as part of the build step. Hence there shouldn't be much point in manually loading `compatibility.js` in `viewer.html` the way that we've been doing, especially considering that it's already being loaded by `src/shared/util.js`.
…ing in `src/core/jpg.js` (issue 4901) This patch removes the `clamp0to255` helper function, as well as manual clamping code in `src/core/jpg.js`. The adjusted constants in `_convertCmykToRgb` were taken from CMYK to RGB conversion code found in `src/core/colorspace.js`. *Please note:* There will be some very slight movement in a number of existing test-cases, since `Uint8ClampedArray` appears to use `Math.round` (or equivalent) and the old code used (basically) `Math.floor`.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6cb9db211f0c302/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6cb9db211f0c302/output.txt Total script time: 2.36 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f3fb7f15631a06d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/2bd18b763c1a113/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/f3fb7f15631a06d/output.txt Total script time: 16.58 mins
Image differences available at: http://54.67.70.0:8877/f3fb7f15631a06d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/2bd18b763c1a113/output.txt Total script time: 29.46 mins
Image differences available at: http://54.215.176.217:8877/2bd18b763c1a113/reftest-analyzer.html#web=eq.log |
|
I wonder if we shall further clean up our polyfills in util.js and compatibility.js and also remove from global space (like we did with streams). So for typed arrays we can add typedarray_polyfill.js and re-export it in util.js. In files that are using Uint8ClampedArray we will start using imported from util.js (or directly from typedarray_polyfill.js) constructor. |
|
In this PR, I figured that it'd make sense to only make the minimal amount of changes required to support
If we want to change this, could that perhaps be done in a follow-up[1] instead to avoid too much scope creep here? [1] It would probably even qualify for the |
Fair enough. Make sure that this polyfill will not appear in mozilla-central build. Other than that, it looks good |
Locally on Windows, I get the results as below (all sizes in bytes) for the
|
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/dca7b4f8fea3f9f/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7c7b16ed5ccd541/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/7c7b16ed5ccd541/output.txt Total script time: 15.34 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/dca7b4f8fea3f9f/output.txt Total script time: 27.67 mins
|
|
Really nice! |
Use `Uint8ClampedArray`, when returning data, and remove manual clamping in `src/core/jpg.js` (issue 4901)
This patch removes the
clamp0to255helper function, as well as manual clamping code insrc/core/jpg.js.The adjusted constants in
_convertCmykToRgbwere taken from CMYK to RGB conversion code found insrc/core/colorspace.js.Please note: There will be some very slight movement in a number of existing test-cases, since
Uint8ClampedArrayappears to useMath.round(or equivalent) and the old code used (basically)Math.floor.Fixes #4901.