Use Uint8ClampedArray when returning image data in src/core/jbig2.js and src/core/jpg.js
#8783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble with both `Uint8Array` and `Uint8ClampedArray`
…js` and `src/core/jpg.js`
Since we're now using `Uint8ClampedArray`, rather than `Uint8Array`, doing manual clamping shouldn't be necessary given that that is now handled natively.
This shouldn't have any measurable performance impact, but just to sanity check that I've done some quick benchmarking with the following manifest file:
```json
[
{ "id": "S2-eq",
"file": "pdfs/S2.pdf",
"md5": "d0b6137846df6e0fe058f234a87fb588",
"rounds": 100,
"type": "eq"
}
]
```
which gave the following results against the current `master` (repeated benchmark runs didn't result in any meaningful differences):
```
-- Grouped By browser, stat --
browser | stat | Count | Baseline(ms) | Current(ms) | +/- | % | Result(P<.05)
------- | ------------ | ----- | ------------ | ----------- | --- | ----- | -------------
firefox | Overall | 100 | 592 | 592 | 1 | 0.12 |
firefox | Page Request | 100 | 3 | 3 | 0 | -9.88 |
firefox | Rendering | 100 | 588 | 589 | 1 | 0.18 |
```
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ddc6399ecd03d28/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/1a58469edbb22ae/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ddc6399ecd03d28/output.txt Total script time: 16.39 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/1a58469edbb22ae/output.txt Total script time: 29.64 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/602f54cfa6813b8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/602f54cfa6813b8/output.txt Total script time: 2.34 mins Published |
timvandermeij
approved these changes
Aug 16, 2017
|
Looks good. Thank you! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…t8ClampedArray Use `Uint8ClampedArray` when returning image data in `src/core/jbig2.js` and `src/core/jpg.js`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following was done in a separate commit, to make it easy to revert just in case it's not a desired change: Remove manual clamping code in
src/core/jpx.jsSince we're now using
Uint8ClampedArray, rather thanUint8Array, doing manual clamping shouldn't be necessary given that that is now handled natively.This shouldn't have any measurable performance impact, but just to sanity check that I've done some quick benchmarking with the following manifest file:
[ { "id": "S2-eq", "file": "pdfs/S2.pdf", "md5": "d0b6137846df6e0fe058f234a87fb588", "rounds": 100, "type": "eq" } ]which gave the following results against the current
master(repeated benchmark runs didn't result in any meaningful differences):