SVG: Don't render missing glyphs #8785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug is similar to the canvas bug of mozilla#6721. I found this bug when I tried to run pdf2svg on a SVG file, and the generated SVG could not be viewed in Chrome due to a SVG/XML parsing error: "PCDATA invalid Char value 3" Reduced test case: - https://github.com/mozilla/pdf.js/files/1229507/pcdatainvalidchar.pdf - expected: "hardware performance" - Actual SVG source: "hardware\x03performance" (where "\x03" is a non-printable character, and invalid XML). In terms of rendering, this bug is similar to mozilla#6721, where an unexpected glyph appeared in the canvas renderer. This was fixed by mozilla#7023, which skips over missing glyphs. This commit follows a similar logic. The test case from mozilla#6721 can be used here too: - https://github.com/mozilla/pdf.js/files/52205/issue6721_reduced.pdf expected: "Issue 6721" actual (before this patch): "Issue ààà6721"
Rob--W
force-pushed
the
svg-ignore-missing-glyph
branch
from
2941dc3
to
f07ce2b
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d3673cdf35b4ecb/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/d3673cdf35b4ecb/output.txt Total script time: 2.35 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f8aa5e6f8b8039b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/76d0a9ffaa84bce/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f8aa5e6f8b8039b/output.txt Total script time: 16.44 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/76d0a9ffaa84bce/output.txt Total script time: 29.30 mins
|
timvandermeij
approved these changes
Aug 17, 2017
|
Thank you for fixing this! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
SVG: Don't render missing glyphs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is similar to the canvas bug of #6721, which was fixed by #7023
See commit description for more info and test cases.
New reduced test case introduced with this PR:
node examples/node/pdf2svg.js pcdatainvalidchar.pdf): "hardware\x03performance"(I did not add an automated test because we don't have any ref test framework for SVG (e.g. painting SVG on a canvas, and then doing an image comparison, as done in #5863 - somehow that issue was closed without follow-up...).
The test case from #6721 can be used here too: