Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to delay disabling of the attachment view until FileAttachment annotations of the *initial* page has been parsed #8788

Merged
merged 2 commits into from
Aug 17, 2017
Merged

Attempt to delay disabling of the attachment view until FileAttachment annotations of the *initial* page has been parsed #8788

merged 2 commits into from
Aug 17, 2017

Commits on Aug 17, 2017

  1. Call the reset() methods in the PDFAttachmentViewer and `PDFOutli… 

    …neViewer` constructors

Rather than duplicating initialization code, we can just call `this.reset()` instead (which is also similar to other existing code, e.g. `PDFViewer`). This will also help ensure that the DOM is completely reset, before any outline items or attachments are displayed.
    @Snuffleupagus
    Snuffleupagus committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    96fb0c0 View commit details
    Browse the repository at this point in the history

  2. Attempt to delay disabling of the attachment view until FileAttachmen… 

    …t annotations of the *initial* page has been parsed

As discussed in PR 8673, we cannot solve the general issue (since that would require parsing every single page). However, we can mitigate the effect somewhat, by waiting for the FileAttachment annotations of the initially rendered page.
    @Snuffleupagus
    Snuffleupagus committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    9273350 View commit details
    Browse the repository at this point in the history