Fix caching of small inline images in Parser.makeInlineImage (issue 8790)
#8792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 8790) *Follow-up to PR 5445.* Using the PDF file from issue 2618, i.e. http://bugzilla-attachments.gnome.org/attachment.cgi?id=226471, with the following manifest file: ```json [ { "id": "issue2618", "file": "../web/pdfs/issue2618.pdf", "md5": "", "rounds": 50, "type": "eq" } ] ``` I get the following results when comparing `master` against this patch: ``` browser | stat | Count | Baseline(ms) | Current(ms) | +/- | % | Result(P<.05) ------- | ------------ | ----- | ------------ | ----------- | ---- | ------ | ------------- firefox | Overall | 50 | 4694 | 3974 | -721 | -15.35 | faster firefox | Page Request | 50 | 2 | 1 | 0 | -22.83 | firefox | Rendering | 50 | 4692 | 3972 | -720 | -15.35 | faster ``` So, based on these results, it seems like a fairly clear win to fix this broken caching :-)
I've gotten tired of having to manually re-install the `ttest` package on numerous occasions when benchmarking changes, so let's just list it in package.json to simplify things.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4f2880d2dfeddbe/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/181618a2fcf9116/output.txt |
yurydelendik
approved these changes
Aug 18, 2017
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4f2880d2dfeddbe/output.txt Total script time: 16.45 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/181618a2fcf9116/output.txt Total script time: 29.45 mins
|
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Fix caching of small inline images in `Parser.makeInlineImage` (issue 8790)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #5445.
Using the PDF file from issue #2618, i.e. http://bugzilla-attachments.gnome.org/attachment.cgi?id=226471, with the following manifest file:
[ { "id": "issue2618", "file": "../web/pdfs/issue2618.pdf", "md5": "", "rounds": 50, "type": "eq" } ]I get the following results when comparing
masteragainst this patch:So, based on these results, it seems like a fairly clear win to fix this broken caching :-)
Fixes #8790.