Remove handling of fallback arguments from PDFViewer.scrollPageIntoView
#8807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew` The method signature was improved in PR 7440, which has now been present in a number of releases (starting with `v1.6.210`). Hence we should be able to remove this now, and just print an error message if the old format is used.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/150e24b5b051bfc/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/150e24b5b051bfc/output.txt Total script time: 2.33 mins Published |
timvandermeij
approved these changes
Aug 22, 2017
|
Nice clean-up. Thank you! |
Snuffleupagus
deleted the
PDFViewer-scrollPageIntoView-rm-fallback-args
branch
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…geIntoView-rm-fallback-args Remove handling of fallback arguments from `PDFViewer.scrollPageIntoView`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method signature was improved in PR #7440, which has now been present in a number of releases (starting with
v1.6.210).Hence we should be able to remove this now, and just print an error message if the old format is used.