-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set this.isCancelled in close method of streamSink. #8817
Set this.isCancelled in close method of streamSink. #8817
Conversation
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e49fe04a88372a2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/deef3b564502e27/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e49fe04a88372a2/output.txt Total script time: 2.53 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/deef3b564502e27/output.txt Total script time: 12.50 mins
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/1055e97a251dfcc/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 1 Live output at: http://54.67.70.0:8877/4fbb708eccff45f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4fbb708eccff45f/output.txt Total script time: 2.54 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/1055e97a251dfcc/output.txt Total script time: 12.74 mins
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6c1c03396d4cf11/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/b53564c8667caaa/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6c1c03396d4cf11/output.txt Total script time: 16.51 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/b53564c8667caaa/output.txt Total script time: 29.68 mins
|
Looks good. Thank you! |
Set this.isCancelled in close method of streamSink.
Fixes #8816 . This PR tries to fix the intermittent error
Error: close should have stream controller thrown
raised during unit tests.I cannot see where we are setting
sink.isCancelled = true
, when close() method of streamSink is called. So, I think addingthis.isCancelled = true;
in close() method itself, may fix this intermittent error.@timvandermeij can you please check if this fixes the problem, as I cannot reproduce this error locally.