Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set this.isCancelled in close method of streamSink. #8817

Merged
merged 1 commit into from
Aug 24, 2017

Conversation

mukulmishra18
Copy link
Contributor

@mukulmishra18 mukulmishra18 commented Aug 24, 2017

Fixes #8816 . This PR tries to fix the intermittent error Error: close should have stream controller thrown raised during unit tests.

I cannot see where we are setting sink.isCancelled = true, when close() method of streamSink is called. So, I think adding this.isCancelled = true; in close() method itself, may fix this intermittent error.

@timvandermeij can you please check if this fixes the problem, as I cannot reproduce this error locally.

@Snuffleupagus
Copy link
Collaborator

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e49fe04a88372a2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/deef3b564502e27/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/e49fe04a88372a2/output.txt

Total script time: 2.53 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/deef3b564502e27/output.txt

Total script time: 12.50 mins

  • Unit Tests: Passed

@timvandermeij
Copy link
Contributor

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 1

Live output at: http://54.215.176.217:8877/1055e97a251dfcc/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 1

Live output at: http://54.67.70.0:8877/4fbb708eccff45f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/4fbb708eccff45f/output.txt

Total script time: 2.54 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/1055e97a251dfcc/output.txt

Total script time: 12.74 mins

  • Unit Tests: Passed

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/6c1c03396d4cf11/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/b53564c8667caaa/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/6c1c03396d4cf11/output.txt

Total script time: 16.51 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/b53564c8667caaa/output.txt

Total script time: 29.68 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit d368a5b into mozilla:master Aug 24, 2017
@timvandermeij
Copy link
Contributor

Looks good. Thank you!

@mukulmishra18 mukulmishra18 deleted the intermittent-error branch September 19, 2017 08:23
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Set this.isCancelled in close method of streamSink.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests intermittently raise "Error: close should have stream controller thrown"
4 participants