Prevent an infinite loop in XRef.readXRef by keeping track of already parsed tables (bug 1393476)
#8824
Conversation
…dy parsed tables (bug 1393476) With this patch, not only is the infinite loop prevented, but we're also able to actually render the file (which e.g. Adobe Reader isn't able to). Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1393476.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/759b6e76e63e931/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.67.70.0:8877/83ce1d57ddca463/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/83ce1d57ddca463/output.txt Total script time: 16.53 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/759b6e76e63e931/output.txt Total script time: 29.35 mins
|
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1223ae3db8227e6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/3e931eb666230ec/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/1223ae3db8227e6/output.txt Total script time: 2.58 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/3e931eb666230ec/output.txt Total script time: 12.51 mins
|
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/21b39f22b279e83/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f622734bb94cf94/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f622734bb94cf94/output.txt Total script time: 15.54 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/21b39f22b279e83/output.txt Total script time: 27.47 mins
|
|
I like the simplicity of the patch and the fact that we can actually render this. Awesome! |
Prevent an infinite loop in `XRef.readXRef` by keeping track of already parsed tables (bug 1393476)
Please note that while this passes all tests locally, I don't know if it's necessarily the best solution.
With this patch, not only is the infinite loop prevented, but we're also able to actually render the file (which e.g. Adobe Reader isn't able to).
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1393476.