Attempt to improve the EI detection heuristics, for inline images, in streams containing NUL bytes (issue 8823)
#8829
Conversation
…in streams containing `NUL` bytes (issue 8823) Since this patch will now treat (some) `NUL` bytes as "ASCII", the number of `followingBytes` checked are thus increased to (hopefully) reduce the risk of introducing new false positives. Fixes 8823.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9ead132cb82bf2b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9ead132cb82bf2b/output.txt Total script time: 2.36 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b6382f51049738d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/f888556fb2f4b13/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/b6382f51049738d/output.txt Total script time: 16.35 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/f888556fb2f4b13/output.txt Total script time: 29.70 mins
|
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/343537f3e4854c0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/201ee1f9c65825e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/343537f3e4854c0/output.txt Total script time: 15.50 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/201ee1f9c65825e/output.txt Total script time: 27.45 mins
|
|
The change looks good and it's good to have a regression test for this now. Thanks! |
Attempt to improve the `EI` detection heuristics, for inline images, in streams containing `NUL` bytes (issue 8823)
Please note that while this passes all tests locally, I don't know if it's necessarily the best solution.
Since this patch will now treat (some)
NULbytes as "ASCII", the number offollowingByteschecked are thus increased to (hopefully) reduce the risk of introducing new false positives.Fixes #8823.