Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide unsupported LinkAnnotations (issue 3897) #8865

Merged
merged 2 commits into from
Sep 9, 2017
Merged

Hide unsupported LinkAnnotations (issue 3897) #8865

merged 2 commits into from
Sep 9, 2017

Conversation

Snuffleupagus
Copy link
Collaborator

Rather than displaying links that does nothing when clicked, it probably makes more sense to simply not render them instead. Especially since it turns out that, at least at this point in time, this is very easy to both implement and test.

Fixes #3897.

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Sep 2, 2017

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/3f36d32eeb1fda4/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 2, 2017

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/3f36d32eeb1fda4/output.txt

Total script time: 2.31 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Sep 2, 2017

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/9a5a6513543c1ec/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 2, 2017

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/efdc35014a7c802/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 2, 2017

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/9a5a6513543c1ec/output.txt

Total script time: 16.40 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Sep 2, 2017

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/efdc35014a7c802/output.txt

Total script time: 29.60 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/efdc35014a7c802/reftest-analyzer.html#web=eq.log

Rather than displaying links that does *nothing* when clicked, it probably makes more sense to simply not render them instead. Especially since it turns out that, at least at this point in time, this is *very* easy to both implement and test.

Fixes 3897.
…TION` mode

This ensures that relative links are displayed when using the viewer in `gulp server` mode, in an effort to aid development/debugging.
@timvandermeij
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Sep 9, 2017

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/ea13c55a27c4eb6/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 9, 2017

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/6203ef0626d7e75/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 9, 2017

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/ea13c55a27c4eb6/output.txt

Total script time: 15.75 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Sep 9, 2017

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/6203ef0626d7e75/output.txt

Total script time: 27.64 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@timvandermeij timvandermeij merged commit 437e9cb into mozilla:master Sep 9, 2017
@timvandermeij
Copy link
Contributor

Thank you; I'm really happy that this is now so easy to fix!

@Snuffleupagus Snuffleupagus deleted the hide-unsupported-LinkAnnotation branch September 9, 2017 17:50
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
…inkAnnotation

Hide unsupported `LinkAnnotation`s (issue 3897)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants