-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide unsupported LinkAnnotation
s (issue 3897)
#8865
Hide unsupported LinkAnnotation
s (issue 3897)
#8865
Conversation
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3f36d32eeb1fda4/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/3f36d32eeb1fda4/output.txt Total script time: 2.31 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9a5a6513543c1ec/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/efdc35014a7c802/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9a5a6513543c1ec/output.txt Total script time: 16.40 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/efdc35014a7c802/output.txt Total script time: 29.60 mins
Image differences available at: http://54.215.176.217:8877/efdc35014a7c802/reftest-analyzer.html#web=eq.log |
Rather than displaying links that does *nothing* when clicked, it probably makes more sense to simply not render them instead. Especially since it turns out that, at least at this point in time, this is *very* easy to both implement and test. Fixes 3897.
…TION` mode This ensures that relative links are displayed when using the viewer in `gulp server` mode, in an effort to aid development/debugging.
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ea13c55a27c4eb6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6203ef0626d7e75/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ea13c55a27c4eb6/output.txt Total script time: 15.75 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/6203ef0626d7e75/output.txt Total script time: 27.64 mins
|
Thank you; I'm really happy that this is now so easy to fix! |
…inkAnnotation Hide unsupported `LinkAnnotation`s (issue 3897)
Rather than displaying links that does nothing when clicked, it probably makes more sense to simply not render them instead. Especially since it turns out that, at least at this point in time, this is very easy to both implement and test.
Fixes #3897.