Add CDN links #8980

LukasDrgon · 2017-09-30T21:05:07Z

I added jsDelivr CDN links to your site and readme for easier and faster usage. jsDelivr is the fastest opensource CDN available and built specifically for production usage.

Snuffleupagus · 2017-09-30T21:14:19Z

I'm not sure that we, first of all, should (effectively) endorse a specific CDN in this very visible way!?
Secondly, even if we do this, I don't really think that it belongs in https://mozilla.github.io/pdf.js/getting_started, since that page should contain just the bare minimum.
Finally, if added to README.md, it shouldn't be placed in such a way that it takes precedence over the existing "Getting the Code" section (since that is the only thing we can really guarantee works).

Edit: Also, does following these instructions work correctly? Considering that there's no mention of the pdf.worker.js file, and specifically the fact that PDFJS.workerSrc should be set to point to it.

LukasDrgon · 2017-09-30T22:05:44Z

I'm not sure that we, first of all, should (effectively) endorse a specific CDN in this very visible way!?

That is, of course, completely up to you. Most JS projects do provide a CDN link in their README/documentation because it makes using the code easier (and using a CDN is usually better than serving files from your server).

From user's POV, I can say that the getting started page is exactly where I would expect this, in addition to the full zip packages, but I'll be happy to modify this PR if you decide you actually want this somewhere.

jimaek · 2017-09-30T22:12:30Z

Interestingly enough Mozilla has covered jsDelivr before :) https://hacks.mozilla.org/2014/03/jsdelivr-the-advanced-open-source-public-cdn/

yurydelendik · 2017-10-01T02:44:24Z

What jsDelivr provides that cdnjs or npmcdn does not? Does jsDeliver allow cors to access cmaps?

MartinKolarik · 2017-10-01T07:04:09Z

@yurydelendik

Multiple CDN providers, including one in China, which results in better load times.
Also multiple DNS providers, origin server locations, and backup storage system - it's visually explained here and means that even if half of the services we use went down at the same time, jsDelivr would still continue to work.
Support for on-demand minification and bundling of multiple JS/CSS files.
Usage statistics per project/version/file (some developers actually use this to drive certain development decisions).
Similarly to npmcdn, instant updates from npm with zero config, and semver version ranges for auto-updating URLs, such as /npm/pdfjs-dist@1

Does jsDeliver allow cors to access cmaps?

Yes, cors is enabled for all resources.

yurydelendik · 2017-10-01T18:35:40Z

Does jsDeliver allow cors to access cmaps?

Yes, cors is enabled for all resources.

I tested the https://gist.github.com/yurydelendik/016016dcb126ee5c84b4a9c3cc734d8e example. The CORS at jsDeliver does not work. I tested npmcdn.com it works there.

yurydelendik

We want to provide an alternative CDNs and don't want to be exclusive to the jsDelivr. Please rephrase text in neutral language and list available/popular CDNs that host PDF.js at this moment.

yurydelendik · 2017-10-01T17:14:02Z

README.md

@@ -45,6 +45,13 @@ PDF.js is built into version 19+ of Firefox, however, one extension is still ava
 Chrome, go to `Tools > Extension` and load the (unpackaged) extension from the
 directory `build/chromium`.

+### Including via a CDN
+
+To use PDF.js via a CDN you need to include this file from [jsDelivr](https://www.jsdelivr.com/package/npm/pdfjs-dist):


Move this section as ## after the "Building PDF.js"

yurydelendik · 2017-10-01T18:38:40Z

README.md

+
+To use PDF.js via a CDN you need to include this file from [jsDelivr](https://www.jsdelivr.com/package/npm/pdfjs-dist):
+```
+<script src="https://cdn.jsdelivr.net/npm/pdfjs-dist@1/build/pdf.min.js"></script>


We cannot exclusively list only jsdelivr, please list npmcdn.com prior jsdelivr.net since some finality (e.g. cmaps) does not work with the former.

yurydelendik · 2017-10-01T18:39:30Z

docs/contents/getting_started/index.md

@@ -37,6 +37,12 @@ Before downloading PDF.js please take a moment to understand the different layer

 ## Download

+You can use PDF.js by including this file from [jsDelivr](https://www.jsdelivr.com/package/npm/pdfjs-dist):


Remove the text from the download section, list it in the separate section below.

MartinKolarik · 2017-10-01T18:46:14Z

I think you just used a wrong link there. https://www.jsdelivr.com/ is the website, CDN files are on a different domain (for security and other reasons) - https://cdn.jsdelivr.net/npm/pdfjs-dist/cmaps/

yurydelendik · 2017-10-01T18:48:09Z

I think you just used a wrong link there. https://www.jsdelivr.com/ is the website,

Sorry, I just copied what is/was provided at a8d7397#diff-04c6e90faac2675aa89e2176d2eec7d8R50

LukasDrgon · 2017-10-02T19:13:58Z

@yurydelendik Let me know if you want to change anything else.

yurydelendik · 2017-10-02T19:51:52Z

README.md

@@ -88,6 +88,13 @@ This will generate `pdf.js` and `pdf.worker.js` in the `build/generic/build/` di
 Both scripts are needed but only `pdf.js` needs to be included since `pdf.worker.js` will
 be loaded by `pdf.js`. The PDF.js files are large and should be minified for production.

+## Including via a CDN


Can you move this section after ## Using PDF.js in a web application?

timvandermeij · 2017-10-02T19:52:19Z

@LukasDrgon Also, please squash the commits into one commit (see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits) once you made the change requested above.

Add CDN link Add Popular CDNs Add popular CDNs (site) Moving section

LukasDrgon · 2017-10-02T21:02:04Z

All done 👍

timvandermeij · 2017-10-03T20:51:19Z

Thank you for the patch!

Add CDN links

timvandermeij added the other label Oct 1, 2017

yurydelendik requested changes Oct 1, 2017

View reviewed changes

yurydelendik approved these changes Oct 2, 2017

View reviewed changes

yurydelendik reviewed Oct 2, 2017

View reviewed changes

Add CDN link

c2f1ff4

Add CDN link Add Popular CDNs Add popular CDNs (site) Moving section

LukasDrgon force-pushed the patch-1 branch from a2836a2 to c2f1ff4 Compare October 2, 2017 20:17

timvandermeij approved these changes Oct 3, 2017

View reviewed changes

timvandermeij merged commit e279d37 into mozilla:master Oct 3, 2017

movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018

Merge pull request mozilla#8980 from LukasDrgon/patch-1

99da381

Add CDN links

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CDN links #8980

Add CDN links #8980

LukasDrgon commented Sep 30, 2017

Snuffleupagus commented Sep 30, 2017 •

edited

Loading

LukasDrgon commented Sep 30, 2017

jimaek commented Sep 30, 2017

yurydelendik commented Oct 1, 2017 •

edited

Loading

MartinKolarik commented Oct 1, 2017

yurydelendik commented Oct 1, 2017 •

edited

Loading

yurydelendik left a comment

yurydelendik Oct 1, 2017

yurydelendik Oct 1, 2017

yurydelendik Oct 1, 2017

MartinKolarik commented Oct 1, 2017 •

edited

Loading

yurydelendik commented Oct 1, 2017

LukasDrgon commented Oct 2, 2017

yurydelendik Oct 2, 2017

timvandermeij commented Oct 2, 2017

LukasDrgon commented Oct 2, 2017

timvandermeij commented Oct 3, 2017

		@@ -37,6 +37,12 @@ Before downloading PDF.js please take a moment to understand the different layer

		## Download

		You can use PDF.js by including this file from [jsDelivr](https://www.jsdelivr.com/package/npm/pdfjs-dist):

Add CDN links #8980

Add CDN links #8980

Conversation

LukasDrgon commented Sep 30, 2017

Snuffleupagus commented Sep 30, 2017 • edited Loading

LukasDrgon commented Sep 30, 2017

jimaek commented Sep 30, 2017

yurydelendik commented Oct 1, 2017 • edited Loading

MartinKolarik commented Oct 1, 2017

yurydelendik commented Oct 1, 2017 • edited Loading

yurydelendik left a comment

Choose a reason for hiding this comment

yurydelendik Oct 1, 2017

Choose a reason for hiding this comment

yurydelendik Oct 1, 2017

Choose a reason for hiding this comment

yurydelendik Oct 1, 2017

Choose a reason for hiding this comment

MartinKolarik commented Oct 1, 2017 • edited Loading

yurydelendik commented Oct 1, 2017

LukasDrgon commented Oct 2, 2017

yurydelendik Oct 2, 2017

Choose a reason for hiding this comment

timvandermeij commented Oct 2, 2017

LukasDrgon commented Oct 2, 2017

timvandermeij commented Oct 3, 2017

Snuffleupagus commented Sep 30, 2017 •

edited

Loading

yurydelendik commented Oct 1, 2017 •

edited

Loading

yurydelendik commented Oct 1, 2017 •

edited

Loading

MartinKolarik commented Oct 1, 2017 •

edited

Loading