Only warn about unsupported JavaScript, in the viewer, when non-empty actions exist (issue 5767) #9009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
… actions exist (issue 5767) Some PDF files contain JavaScript actions that consist of nothing more that one, or possibly several, empty string(s). At least to me, printing a warning/showing the fallback seems completely unnecessary in that case. Furthermore, this patch also makes use of an early `return`, so that we no longer will attempt to check for printing instructions when no JavaScript is present in the PDF file. *Note:* It would perhaps make sense to change the API/core code, such that we ignore empty entries there instead. However, that would probably be considered a breaking changing with respect to backwards compatibility, hence this simple viewer only solution. Fixes 5767.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f6c2559a1a334e8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f6c2559a1a334e8/output.txt Total script time: 2.58 mins Published |
timvandermeij
approved these changes
Oct 8, 2017
|
Thank you! |
Merged
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Only warn about unsupported JavaScript, in the viewer, when non-empty actions exist (issue 5767)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some PDF files contain JavaScript actions that consist of nothing more that one, or possibly several, empty string(s). At least to me, printing a warning/showing the fallback seems completely unnecessary in that case.
Furthermore, this patch also makes use of an early
return, so that we no longer will attempt to check for printing instructions when no JavaScript is present in the PDF file.Note: It would perhaps make sense to change the API/core code, such that we ignore empty entries there instead. However, that would probably be considered a breaking changing with respect to backwards compatibility, hence this simple viewer only solution.
Fixes #5767.
Edit: The existing test-files
issue6106.pdfandbug1001080.pdfcould be used to check that this patch doesn't break the warning/fallback in cases where it's still applicable.Edit2: Patch updated only to fix stupid typos in the commit message!