Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the check, and remove the warning, for the nativeImageDecoderSupport API parameter #9032

Merged
merged 2 commits into from
Oct 20, 2017
Merged

Simplify the check, and remove the warning, for the nativeImageDecoderSupport API parameter #9032

merged 2 commits into from
Oct 20, 2017

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Oct 15, 2017

As discussed in PR #8982 (comment).

TODO

  • Check if we possibly need to include core-js polyfills for Object.values and/or Array.includes.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/b8847172b5c37d2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/b8847172b5c37d2/output.txt

Total script time: 2.40 mins

Published

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/11bf29dadeaff49/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/1b4900030a85e9c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/1b4900030a85e9c/output.txt

Total script time: 16.87 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/11bf29dadeaff49/output.txt

Total script time: 30.26 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit 10fd590 into mozilla:version-2.0 Oct 20, 2017
@timvandermeij
Copy link
Contributor

Good improvement!

@Snuffleupagus Snuffleupagus deleted the nativeImageDecoderSupport-2.0 branch October 20, 2017 21:20
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
…Support-2.0

Simplify the check, and remove the warning, for the `nativeImageDecoderSupport` API parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants