Handle broken, Ghostscript generated, Metadata that contains HTML character names (bug 1424938) #9271
Conversation
…racter names (bug 1424938) Please note that while this could be considered a regression in user-facing behaviour, I'm not convinced that it's really a regression as such since prior to PR 8912 the Metadata would fail to parse (with an XML error) and thus be ignored when setting the viewer title. With the refactored Metadata parsing we're now able to parse this, which uncovered issues with a subset of broken Ghostscript Metadata that uses HTML character names. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1424938
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6bf00d25d7cc702/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/136bcca90aa6128/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6bf00d25d7cc702/output.txt Total script time: 2.78 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/136bcca90aa6128/output.txt Total script time: 6.09 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0f6fda3c235e799/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/0f6fda3c235e799/output.txt Total script time: 2.48 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d6bf70e7eed7be9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/4f82607a24ede1d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/d6bf70e7eed7be9/output.txt Total script time: 16.99 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/4f82607a24ede1d/output.txt Total script time: 23.47 mins
Image differences available at: http://54.215.176.217:8877/4f82607a24ede1d/reftest-analyzer.html#web=eq.log |
|
Thank you for fixing this! |
Handle broken, Ghostscript generated, Metadata that contains HTML character names (bug 1424938)
Please note that while this could be considered a regression in user-facing behaviour, I'm not convinced that it's really a regression as such since prior to PR #8912 the Metadata would fail to parse (with an XML error) and thus be ignored when setting the viewer title.
With the refactored Metadata parsing we're now able to parse this, which uncovered issues with a subset of broken Ghostscript Metadata that uses HTML character names.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1424938