Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated new Buffer(string, 'base64') constructor with `Buffer.from(string, 'base64') #9801

Merged

Conversation

yungRoz
Copy link
Contributor

@yungRoz yungRoz commented Jun 12, 2018

Fixes #9797.

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/52d94102ca934f8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/d4a210036de5491/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/d4a210036de5491/output.txt

Total script time: 23.45 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/d4a210036de5491/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/52d94102ca934f8/output.txt

Total script time: 39.26 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit b590519 into mozilla:master Jun 13, 2018
@timvandermeij
Copy link
Contributor

Thank you for your contribution!

The failing reference tests have nothing to do with this pull request and are known to be intermittent.

movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
…r-constructor

Replace deprecated `new Buffer(string, 'base64')` constructor with `Buffer.from(string, 'base64')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants