Add unit-tests for PDFPageProxy.stats (PR 9245 follow-up)
#9839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wasn't included in PR 9245, since all the API options were still global at that time. Writing the unit-tests also uncovered an issue with `getOperatorList` not starting the "Page Request" timer.
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/a1c1e743bbc41ad/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/316dd86ccb1fd3e/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/a1c1e743bbc41ad/output.txt Total script time: 5.71 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/316dd86ccb1fd3e/output.txt Total script time: 9.18 mins
|
timvandermeij
approved these changes
Jun 25, 2018
|
Good expansion of the unit test coverage; thanks! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Add unit-tests for `PDFPageProxy.stats` (PR 9245 follow-up)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't included in PR #9245, since all the API options were still global at that time.
Writing the unit-tests also uncovered an issue with
getOperatorListnot starting the "Page Request" timer.