Convert more code in the /src folder to use ES6 classes, such that Util.inherit can be removed
#9887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…141 follow-up) PR 6141 changed `CompiledFont.compileGlyph` to, in the general case, return an Array. However, that PR apparenly forgot to update the no-glyph, empty-glyph, and endchar-glyph code-path and a String was still being (incorrectly) returned. Given the way that `FontFaceObject.getPathGenerator` (on the API side) is implemented, this shouldn't have caused any bugs despite the Worker possible returning unexpected data.
…6 classes Also changes `var` to `let`/`const` in code already touched in the patch.
Also changes `var` to `let`/`const` in code already touched in the patch.
Also changes `var` to `let`/`const` in code already touched in the patch.
Compared to all the other (static) methods in `Util`, the `toRoman` one looks slightly out of place. Even more so considering that `Util` is being exposed through `pdfjsLib`, where access to a Roman numerals conversion method doesn't make much sense.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/3cf1f1a3439e217/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/343d41b97a99af8/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/3cf1f1a3439e217/output.txt Total script time: 24.39 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/343d41b97a99af8/output.txt Total script time: 38.47 mins
|
timvandermeij
approved these changes
Jul 14, 2018
|
Nice clean-up! It's really good to reduce the dependency on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared to the time when ES6 classes were originally introduced in the
/webfolder, things have now improved/changed:/srcfolder, with (seemingly) no ill effects./srcfolder to use proper ES6 classes, theUtil.inheritfunction may be replaced by native code.Much more manageable diff with: https://github.com/mozilla/pdf.js/pull/9887/files?w=1