Provide custom messages for the no-restricted-globals ESLint rule, and refactor the .eslintrc files (PR 9868 follow-up)
#9913
Conversation
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/454b8dfeda52323/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b9a29e8598db3e1/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/454b8dfeda52323/output.txt Total script time: 2.63 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/b9a29e8598db3e1/output.txt Total script time: 19.13 mins
|
…and refactor the `.eslintrc` files (PR 9868 follow-up) Without providing useful (custom) error messages for the `no-restricted-globals` rule, see https://eslint.org/docs/rules/no-restricted-globals, it's quite likely that the rule will be incorrectly disabled rather than the required globals being imported as intended. To reduced duplication of the `no-restricted-globals` rule in multiple `.eslintrc` files, it's instead moved to the top-level `.eslintrc` file and disabled as needed on a folder/file basis outside of `/src` and `/web`.
Snuffleupagus
force-pushed
the
no-restricted-globals
branch
from
6b152f8
to
36b683c
Compare
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/3e879dcef037563/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d8158b4f9002ef0/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/3e879dcef037563/output.txt Total script time: 2.76 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/d8158b4f9002ef0/output.txt Total script time: 18.87 mins
|
|
Nice find! I didn't know that was possible, but it should help to make it clear why we have this. |
Without providing useful (custom) error messages for the
no-restricted-globalsrule, see https://eslint.org/docs/rules/no-restricted-globals, it's quite likely that the rule will be incorrectly disabled rather than the required globals being imported as intended.To reduced duplication of the
no-restricted-globalsrule in multiple.eslintrcfiles, it's instead moved to the top-level.eslintrcfile and disabled as needed on a folder/file basis outside of/srcand/web.