Add a BasePreferences.getAll method and use it to fetch all Preferences at once in PDFViewerApplication._readPreferences; ensure that the externalLinkTarget option is correctly set when the viewer is embedded
#9917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
Preference-getAll
branch
from
49ac3ae
to
a62d087
Compare
Snuffleupagus
changed the title
BasePreferences.getAll menthod and use it to fetch all Preferences at once in PDFViewerApplication._readPreferences; and ensure that the externalLinkTarget option is correctly set when the viewer is embeddedBasePreferences.getAll method and use it to fetch all Preferences at once in PDFViewerApplication._readPreferences; ensure that the externalLinkTarget option is correctly set when the viewer is embedded
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/03703f47f0e9343/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/03703f47f0e9343/output.txt Total script time: 4.90 mins Published |
… viewer is embedded (PR 9479 follow-up) *This was a stupid error on my part; sorry about breaking this!* With the current code, the value of the `externalLinkTarget` option is now (potentially) updated *after* the viewer components have been initialized. For the "viewer in iframe/object tag" case, the result is that the value of the `externalLinkTarget` option isn't adjusted as intended any more.
…plication._readPreferences` The only reason that this check ever existed in the first place, is that originally there was a global `PDFJS.openExternalLinkInNewWindow` option which was then subsumed by the (more generic) `PDFJS.externalLinkTarget` option. (The `externalLinkTarget` has since been moved into a `PDFLinkService` option, as part of PDF.js version `2.0`.) Hence, during the period where both `PDFJS.openExternalLinkInNewWindow` and `PDFJS.externalLinkTarget` existed side-by-side, there was a need to allow the former one to override the latter one (for backward compatibility purposes). However, that's no longer the case, and this extra `externalLinkTarget` check can now be removed.
…nces at once in `PDFViewerApplication._readPreferences` Given that *all* Preferences are already fetched in `PDFViewerApplication._readPreferences`, the amount of boilerplate/duplication can be considerably reduced with the addition of a `BasePreferences.getAll` method.
Snuffleupagus
force-pushed
the
Preference-getAll
branch
2 times, most recently
from
b9c4171
to
34957ec
Compare
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/3171e73b8a8aaf7/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/3171e73b8a8aaf7/output.txt Total script time: 4.70 mins Published |
timvandermeij
approved these changes
Jul 25, 2018
|
Much simpler; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commit messages for additional details.
@timvandermeij The first patch fixes a (small) regression from PR #9479, hence this one should probably be included in the updated
2.0.xyzrelease too (as tracked in https://github.com/mozilla/pdf.js/projects/5).