Re-factor destinations/getDestination to reduce unnecessary duplication, and reject non-string inputs
#9975
Conversation
…e unnecessary duplication Currently, these two methods contain the same boilerplate code for getting the /Dests data.
Note how e.g. the `getPage` method does basic validation of the input.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/eccf390b0f88f4b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/0ab64bc48232093/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/0ab64bc48232093/output.txt Total script time: 6.90 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/eccf390b0f88f4b/output.txt Total script time: 7.98 mins
|
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ffec1b6710e00aa/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/68c7eb766e16abe/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/68c7eb766e16abe/output.txt Total script time: 29.06 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ffec1b6710e00aa/output.txt Total script time: 36.71 mins
|
|
Nice clean-up! |
Re-factor
destinations/getDestination, in theCatalog, to reduce unnecessary duplicationCurrently, these two methods contain the same boilerplate code for getting the /Dests data.
Reject
getDestination, in the API, for non-string inputsNote how e.g. the
getPagemethod does basic validation of the input.